Add video search in user playlist feature #4622

PikachuEXE · 2024-01-31T07:57:05Z

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Related issue

Code based on #4597
So maybe reviewing the code after that PR is merged

Description

Add button to single playlist view for user playlists to search for videos
Visible videos changes based on input & video titles

Screenshots

Testing

Ensure remote playlist view remains unchanged
Ensure new button shown on user playlist view
Ensure search mode can be entered and exited (and visible videos reverted to all videos when exited)
Ensure pagination from Playlist performance improvements #4597 applied even when displaying matching videos
Ensure cannot move video position when search mode entered
Ensure can remove video items correctly when search mode entered
Ensure a message shown when there are no search results
Ensure search results showing only some videos show original indexes
Ensure exiting search mode would move focus back to search button
Ensure search button hidden in empty user playlists

Desktop

OS:
OS Version:
FreeTube version:

Additional context

github-actions · 2024-02-01T12:11:09Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…function

…agination limit

github-actions · 2024-02-01T12:43:05Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-02-02T20:47:13Z

Shouldnt the focus stay on the search button when i cancel the search?

VirtualBoxVM_wzPZm5yOY6.mp4

Umm maybe discussion is needed here but i dont the numbering in the list should change. 2 reasons against it, 1) when i click on a video to watch that is presented as nr 2 in the search it wont be nr 2 on the player page. This could lead to confusion, users can think that we support playing videos within a playlist with certain words are in it 2) That number can be used as reference point, e.g. i searched for something that is 93 in the list and i know around that video number are videos that im searching for but cant find it with search so i can go to that number in the list and start looking from there

VirtualBoxVM_tNkVsGKHjY.mp4

efb4f5ff-1298-471a-8973-3d47447115dc

Canceling search drops error bomb

VirtualBoxVM_q6YSlWAkp6.mp4

We need to show a message here when there are no results

VirtualBoxVM_TR3UWr4ilr.mp4

PikachuEXE · 2024-02-03T02:58:58Z

Canceling search drops error bomb

Cannot reproduce

We need to show a message here when there are no results

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-02-06T22:25:56Z

Canceling search drops error bomb

Cannot reproduce

Did some digging around and i think i found reproducible steps

Create playlist with duplicates
search for one of the duplicate vids
cancel search
error

VirtualBoxVM_gvCqGi7hRQ.mp4

PikachuEXE · 2024-02-07T00:53:43Z

Cannot reproduce (I did cancel afterward, lazy to make video)

I did see that error sometimes in watch page (in my custom build) when I watch videos
I think it's related to visibility detection code but I have no way to reproduce it reliably

However it's not an issue created by this PR

github-actions · 2024-02-15T08:04:38Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…-user-playlist-2 * development: (66 commits) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (Turkish) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Fix overflow issue with share playlist icon drop-down (FreeTubeApp#4677) Fix the Invidious DASH manifest generation (FreeTubeApp#4672) Hide channel sidebar label under `more` when setting is enabled (FreeTubeApp#4678) Translated using Weblate (Norwegian Nynorsk) Translated using Weblate (Serbian) Remove excessive punctuation as part of distraction settings (FreeTubeApp#4673) Bump the stylelint group with 1 update (FreeTubeApp#4669) Bump swiper from 11.0.5 to 11.0.6 (FreeTubeApp#4670) ... # Conflicts: # src/renderer/components/playlist-info/playlist-info.scss

github-actions · 2024-02-15T23:16:15Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

…-user-playlist-2 * development: (37 commits) Fix local API search erroring, because the default parameter values were not getting applied (FreeTubeApp#4704) Hide date and views separator on the watch page when views are hidden (FreeTubeApp#4697) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (Estonian) Bump webpack from 5.90.1 to 5.90.3 (FreeTubeApp#4696) Bump sass from 1.70.0 to 1.71.0 (FreeTubeApp#4693) Bump electron from 28.2.2 to 28.2.3 (FreeTubeApp#4692) Bump the stylelint group with 1 update (FreeTubeApp#4691) Remove unused isLoading from ft-community-post (FreeTubeApp#4684) Include swiper version in CSS file name, for cache busting (FreeTubeApp#4685) Translated using Weblate (Chinese (Traditional)) Fix local API erroring when the view count is missing on the channel shorts tab (FreeTubeApp#4689) Translated using Weblate (Croatian) Translated using Weblate (Polish) Fix Hungarian Locale Name (FreeTubeApp#4686) Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (Spanish) Bump marked from 11.2.0 to 12.0.0 (FreeTubeApp#4638) ...

PikachuEXE · 2024-02-22T23:03:25Z

Updated!
When will this be reviewed -,-...

absidue · 2024-02-23T19:47:19Z

When will this be reviewed -,-...
Now

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-02-23T19:52:20Z

@absidue looking for help on #4622 (comment)

absidue · 2024-02-23T20:09:28Z

Shouldnt the focus stay on the search button when i cancel the search?

Yes, it should.

Umm maybe discussion is needed here but i dont the numbering in the list should change.

It's not very efficient, but hopefully if it's only applicable in search mode, it shouldn't be too bad (presumably most people will be using pretty exact queries, so it won't have to do it for too many items).

<ft-list-video-numbered
...
  :playlist-index="!playlistInVideoSearchMode ? index : playlistItems.findIndex(i => i === item)"
  :video-index="!playlistInVideoSearchMode ? index : playlistItems.findIndex(i => i === item)"
...
/>

PikachuEXE · 2024-02-23T23:21:28Z

Oh this is because I keep missing comments when you have 2 (or more) in a row (It jumps me to latest review when I click the link on email)

…ndexes

PikachuEXE · 2024-02-24T03:03:52Z

Done these (added to testing)

Ensure search results showing only some videos show original indexes
Ensure exiting search mode would move focus back to search button

efb4f5ff-1298-471a-8973-3d47447115dc

lets hide search when there are no vids in the list

PikachuEXE · 2024-02-26T01:33:39Z

Done~

efb4f5ff-1298-471a-8973-3d47447115dc

Edit mode does not hide options on the thumbnail anymore

VirtualBoxVM_Q4pBG375lO.mp4

…-user-playlist-2 * development: Translated using Weblate (Basque) Prevent layout shifts when thumbnails load in the chapter selector (FreeTubeApp#4713) Bump electron-builder from 24.9.1 to 24.12.0 (FreeTubeApp#4718) Bump sass-loader from 14.1.0 to 14.1.1 (FreeTubeApp#4719) Bump sass from 1.71.0 to 1.71.1 (FreeTubeApp#4716) Bump the eslint group with 2 updates (FreeTubeApp#4715) Support opening video timestamps in a new window (FreeTubeApp#4687) Translated using Weblate (Basque) Bump webpack-dev-server from 4.15.1 to 5.0.2 (FreeTubeApp#4695) Translated using Weblate (Japanese) Translated using Weblate (Czech) Translated using Weblate (Lithuanian) Translated using Weblate (Japanese) Translated using Weblate (Vietnamese) Bump youtubei.js to 9.1.0 for watch page fix (FreeTubeApp#4707) Translated using Weblate (Vietnamese) Translated using Weblate (Vietnamese) Translated using Weblate (Portuguese (Brazil))

PikachuEXE · 2024-02-27T00:38:42Z

I checked latest dev and edit mode does not disable any action on video too
Edit mode only updates title and description, no idea why we disable video actions when edit mode is on (We can but I have no idea why nor it's an issue of this PR)

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-02-27T04:37:54Z

Hmm weird because i definitely saw this do that in this PR. I might be imagining things srry about that

* development: (161 commits) Add video search in user playlist feature (FreeTubeApp#4622) Add discussion info when opening an issue (FreeTubeApp#4676) Translated using Weblate (Lithuanian) Translated using Weblate (Serbian) Translated using Weblate (Estonian) Bump mini-css-extract-plugin from 2.8.0 to 2.8.1 (FreeTubeApp#4742) Bump electron from 28.2.3 to 29.1.0 (FreeTubeApp#4743) Bump lefthook from 1.6.1 to 1.6.4 (FreeTubeApp#4740) Bump the babel group with 2 updates (FreeTubeApp#4739) Bump swiper from 11.0.6 to 11.0.7 (FreeTubeApp#4741) Bump electron-builder from 24.12.0 to 24.13.3 (FreeTubeApp#4744) Split view count and published date into two lines on small displays (FreeTubeApp#4736) Translated using Weblate (Chinese (Traditional)) Fix URL copied via right click menu (FreeTubeApp#4690) Translated using Weblate (Croatian) Wrap ft-icon buttons below before they go fully vertical (FreeTubeApp#4735) * Make activating a chapter selector makes window scroll to top like clicking on timestamp links (FreeTubeApp#4722) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) Make video thumbnails have certain height before image loading starts to avoid layout shifts (FreeTubeApp#4723) ... # Conflicts: # src/renderer/views/Playlist/Playlist.vue

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 31, 2024

FreeTubeBot enabled auto-merge (squash) January 31, 2024 07:57

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 1, 2024

PikachuEXE added 2 commits February 1, 2024 20:41

* Update single playlist view for user playlists to add search video …

0283a42

…function

! Fix load more button appears when searching & visible items under p…

5271a80

…agination limit

PikachuEXE force-pushed the feature/playlist-search-videos-in-one-user-playlist-2 branch from 769626f to 5271a80 Compare February 1, 2024 12:42

github-actions bot removed the PR: merge conflicts / rebase needed label Feb 1, 2024

PikachuEXE requested review from absidue, efb4f5ff-1298-471a-8973-3d47447115dc, ChunkyProgrammer and kommunarr February 1, 2024 12:43

efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 2, 2024

efb4f5ff-1298-471a-8973-3d47447115dc reviewed Feb 2, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 2, 2024

efb4f5ff-1298-471a-8973-3d47447115dc mentioned this pull request Feb 2, 2024

[Feature Request]: Add search field to playlists PikachuEXE/FreeTube#64

Closed

3 tasks

* Show message when search returns no result

b60fdff

github-actions bot added the PR: merge conflicts / rebase needed label Feb 15, 2024

github-actions bot removed the PR: merge conflicts / rebase needed label Feb 15, 2024

PikachuEXE removed the PR: changes requested label Feb 19, 2024

PikachuEXE force-pushed the feature/playlist-search-videos-in-one-user-playlist-2 branch from df1a811 to 0bb522c Compare February 22, 2024 23:02

absidue previously approved these changes Feb 23, 2024

View reviewed changes

absidue requested a review from MarmadileManteater February 23, 2024 19:47

PikachuEXE added 2 commits February 24, 2024 10:57

* Make search button focused after existing search mode

296cd58

* Make search result show search result show original playlist item i…

027a310

…ndexes

PikachuEXE dismissed absidue’s stale review via 027a310 February 24, 2024 03:02

absidue previously approved these changes Feb 25, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc reviewed Feb 25, 2024

View reviewed changes

* Make search button only appear with video count > 0

70793ca

PikachuEXE dismissed absidue’s stale review via 70793ca February 26, 2024 01:33

efb4f5ff-1298-471a-8973-3d47447115dc reviewed Feb 26, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Feb 27, 2024

View reviewed changes

absidue approved these changes Mar 6, 2024

View reviewed changes

ChunkyProgrammer approved these changes Mar 6, 2024

View reviewed changes

FreeTubeBot merged commit 672803d into FreeTubeApp:development Mar 6, 2024
5 checks passed

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 6, 2024

PikachuEXE mentioned this pull request Mar 8, 2024

Add search playlists with matching videos function #4537

Merged

4 tasks

PikachuEXE deleted the feature/playlist-search-videos-in-one-user-playlist-2 branch April 2, 2024 03:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add video search in user playlist feature #4622

Add video search in user playlist feature #4622

PikachuEXE commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Feb 1, 2024

github-actions bot commented Feb 1, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 2, 2024 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc left a comment •

edited

Loading

PikachuEXE commented Feb 3, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 6, 2024

PikachuEXE commented Feb 7, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

PikachuEXE commented Feb 22, 2024

absidue commented Feb 23, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 23, 2024

absidue commented Feb 23, 2024

PikachuEXE commented Feb 23, 2024

PikachuEXE commented Feb 24, 2024

efb4f5ff-1298-471a-8973-3d47447115dc left a comment

PikachuEXE commented Feb 26, 2024

efb4f5ff-1298-471a-8973-3d47447115dc left a comment

PikachuEXE commented Feb 27, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 27, 2024 •

edited

Loading

Add video search in user playlist feature #4622

Add video search in user playlist feature #4622

Conversation

PikachuEXE commented Jan 31, 2024 • edited Loading

Pull Request Type

Related issue

Description

Screenshots

Testing

Desktop

Additional context

github-actions bot commented Feb 1, 2024

github-actions bot commented Feb 1, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 2, 2024 • edited Loading

efb4f5ff-1298-471a-8973-3d47447115dc left a comment • edited Loading

Choose a reason for hiding this comment

PikachuEXE commented Feb 3, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 6, 2024

PikachuEXE commented Feb 7, 2024 • edited Loading

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

PikachuEXE commented Feb 22, 2024

absidue commented Feb 23, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 23, 2024

absidue commented Feb 23, 2024

PikachuEXE commented Feb 23, 2024

PikachuEXE commented Feb 24, 2024

efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

PikachuEXE commented Feb 26, 2024

efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

PikachuEXE commented Feb 27, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 27, 2024 • edited Loading

PikachuEXE commented Jan 31, 2024 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 2, 2024 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc left a comment •

edited

Loading

PikachuEXE commented Feb 7, 2024 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 27, 2024 •

edited

Loading