Fix local API erroring when the view count is missing on the channel shorts tab #4689
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Feb 18, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 18, 2024
PikachuEXE
approved these changes
Feb 19, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Feb 22, 2024
…n-one-user-playlist-2 * fix/temp/api-ver: (37 commits) workaround Hide date and views separator on the watch page when views are hidden (FreeTubeApp#4697) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (Estonian) Bump webpack from 5.90.1 to 5.90.3 (FreeTubeApp#4696) Bump sass from 1.70.0 to 1.71.0 (FreeTubeApp#4693) Bump electron from 28.2.2 to 28.2.3 (FreeTubeApp#4692) Bump the stylelint group with 1 update (FreeTubeApp#4691) Remove unused isLoading from ft-community-post (FreeTubeApp#4684) Include swiper version in CSS file name, for cache busting (FreeTubeApp#4685) Translated using Weblate (Chinese (Traditional)) Fix local API erroring when the view count is missing on the channel shorts tab (FreeTubeApp#4689) Translated using Weblate (Croatian) Translated using Weblate (Polish) Fix Hungarian Locale Name (FreeTubeApp#4686) Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (Spanish) Bump marked from 11.2.0 to 12.0.0 (FreeTubeApp#4638) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Feb 22, 2024
…-user-playlist-2 * development: (37 commits) Fix local API search erroring, because the default parameter values were not getting applied (FreeTubeApp#4704) Hide date and views separator on the watch page when views are hidden (FreeTubeApp#4697) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (Estonian) Bump webpack from 5.90.1 to 5.90.3 (FreeTubeApp#4696) Bump sass from 1.70.0 to 1.71.0 (FreeTubeApp#4693) Bump electron from 28.2.2 to 28.2.3 (FreeTubeApp#4692) Bump the stylelint group with 1 update (FreeTubeApp#4691) Remove unused isLoading from ft-community-post (FreeTubeApp#4684) Include swiper version in CSS file name, for cache busting (FreeTubeApp#4685) Translated using Weblate (Chinese (Traditional)) Fix local API erroring when the view count is missing on the channel shorts tab (FreeTubeApp#4689) Translated using Weblate (Croatian) Translated using Weblate (Polish) Fix Hungarian Locale Name (FreeTubeApp#4686) Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (Spanish) Bump marked from 11.2.0 to 12.0.0 (FreeTubeApp#4638) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix local API erroring when the view count is missing on the channel shorts tab
Pull Request Type
Description
Currently the local API assumes that all shorts on the shorts channel tab have a view count, it turns out that sometimes it is missing such as with one short on the
@YouTubeMusicchannel.Testing
Visit
@YouTubeMusicchannel (https://youtube.com/@YouTubeMusic) with the local API, it shouldn't error with this pull request.Desktop