Include swiper version in CSS file name, for cache busting #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Feb 17, 2024
ChunkyProgrammer
approved these changes
Feb 18, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 19, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Feb 22, 2024
…n-one-user-playlist-2 * fix/temp/api-ver: (37 commits) workaround Hide date and views separator on the watch page when views are hidden (FreeTubeApp#4697) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (Estonian) Bump webpack from 5.90.1 to 5.90.3 (FreeTubeApp#4696) Bump sass from 1.70.0 to 1.71.0 (FreeTubeApp#4693) Bump electron from 28.2.2 to 28.2.3 (FreeTubeApp#4692) Bump the stylelint group with 1 update (FreeTubeApp#4691) Remove unused isLoading from ft-community-post (FreeTubeApp#4684) Include swiper version in CSS file name, for cache busting (FreeTubeApp#4685) Translated using Weblate (Chinese (Traditional)) Fix local API erroring when the view count is missing on the channel shorts tab (FreeTubeApp#4689) Translated using Weblate (Croatian) Translated using Weblate (Polish) Fix Hungarian Locale Name (FreeTubeApp#4686) Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (Spanish) Bump marked from 11.2.0 to 12.0.0 (FreeTubeApp#4638) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Feb 22, 2024
…-user-playlist-2 * development: (37 commits) Fix local API search erroring, because the default parameter values were not getting applied (FreeTubeApp#4704) Hide date and views separator on the watch page when views are hidden (FreeTubeApp#4697) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (Estonian) Bump webpack from 5.90.1 to 5.90.3 (FreeTubeApp#4696) Bump sass from 1.70.0 to 1.71.0 (FreeTubeApp#4693) Bump electron from 28.2.2 to 28.2.3 (FreeTubeApp#4692) Bump the stylelint group with 1 update (FreeTubeApp#4691) Remove unused isLoading from ft-community-post (FreeTubeApp#4684) Include swiper version in CSS file name, for cache busting (FreeTubeApp#4685) Translated using Weblate (Chinese (Traditional)) Fix local API erroring when the view count is missing on the channel shorts tab (FreeTubeApp#4689) Translated using Weblate (Croatian) Translated using Weblate (Polish) Fix Hungarian Locale Name (FreeTubeApp#4686) Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (Spanish) Bump marked from 11.2.0 to 12.0.0 (FreeTubeApp#4638) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include swiper version in CSS file name, for cache busting
Pull Request Type
Description
As swiper components get their own shadow DOM, they don't have access to any CSS in the main DOM, so we need to inject the necessary CSS into that shadow DOM. To avoid the FreeTube styles unintentionally conflicting with swiper's and breaking things, we create a separate CSS file at build time with only the swiper CSS inside it.
Currently that file gets the name
swiper.css, which works fine but means it stays indentical regardless of which swiper version we are using, which could result in Electron assuming that the file is the same because the file name isn't the same and using the one from it's cache (for the main CSS file webpack adds the hash of the content to the filename). To solve that potential issue, this pull request adds the swiper version to the file name e.g.swiper-11.0.6.css. In this context using the version is okay, because the CSS is inside the Swiper dependency and we don't do any modifications to it on our side, so the only time the CSS would change is because of a swiper update.Screenshots
Testing
CSSDesktop