Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused isLoading from ft-community-post #4684

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Remove unused isLoading from ft-community-post #4684

merged 1 commit into from
Feb 19, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Feb 17, 2024 •
edited
Loading

Remove unused isLoading from ft-community-post

Pull Request Type

  • Other - Code cleanup

Description

The original intention of the isLoading property seems to have been to hide the component while the data was being parsed. As we've since changed to parsing the data and setting isLoading to false, before the component is rendered, the isLoading property is no longer used.

Here is a diagram of how Vue's lifecycle works, we parse the data in the created lifecycle hook: https://vuejs.org/guide/essentials/lifecycle.html#lifecycle-diagram

Testing

Visit the community page on a channel, if it works the same as before, then this pull request didn't break anything.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.19.1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 17, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 17, 2024 10:49
@FreeTubeBot FreeTubeBot merged commit 2f29084 into FreeTubeApp:development Feb 19, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 19, 2024
@absidue absidue deleted the community-post-loading branch February 19, 2024 11:05
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Feb 22, 2024
@PikachuEXE
Merge branch 'fix/temp/api-ver' into feature/playlist-search-videos-i…
df1a811 
…n-one-user-playlist-2

* fix/temp/api-ver: (37 commits)
  workaround
  Hide date and views separator on the watch page when views are hidden (FreeTubeApp#4697)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Polish)
  Translated using Weblate (Estonian)
  Bump webpack from 5.90.1 to 5.90.3 (FreeTubeApp#4696)
  Bump sass from 1.70.0 to 1.71.0 (FreeTubeApp#4693)
  Bump electron from 28.2.2 to 28.2.3 (FreeTubeApp#4692)
  Bump the stylelint group with 1 update (FreeTubeApp#4691)
  Remove unused isLoading from ft-community-post (FreeTubeApp#4684)
  Include swiper version in CSS file name, for cache busting (FreeTubeApp#4685)
  Translated using Weblate (Chinese (Traditional))
  Fix local API erroring when the view count is missing on the channel shorts tab (FreeTubeApp#4689)
  Translated using Weblate (Croatian)
  Translated using Weblate (Polish)
  Fix Hungarian Locale Name (FreeTubeApp#4686)
  Translated using Weblate (Dutch)
  Translated using Weblate (French)
  Translated using Weblate (Spanish)
  Bump marked from 11.2.0 to 12.0.0 (FreeTubeApp#4638)
  ...
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Feb 22, 2024
@PikachuEXE
Merge branch 'development' into feature/playlist-search-videos-in-one…
0bb522c 
…-user-playlist-2

* development: (37 commits)
  Fix local API search erroring, because the default parameter values were not getting applied (FreeTubeApp#4704)
  Hide date and views separator on the watch page when views are hidden (FreeTubeApp#4697)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Polish)
  Translated using Weblate (Estonian)
  Bump webpack from 5.90.1 to 5.90.3 (FreeTubeApp#4696)
  Bump sass from 1.70.0 to 1.71.0 (FreeTubeApp#4693)
  Bump electron from 28.2.2 to 28.2.3 (FreeTubeApp#4692)
  Bump the stylelint group with 1 update (FreeTubeApp#4691)
  Remove unused isLoading from ft-community-post (FreeTubeApp#4684)
  Include swiper version in CSS file name, for cache busting (FreeTubeApp#4685)
  Translated using Weblate (Chinese (Traditional))
  Fix local API erroring when the view count is missing on the channel shorts tab (FreeTubeApp#4689)
  Translated using Weblate (Croatian)
  Translated using Weblate (Polish)
  Fix Hungarian Locale Name (FreeTubeApp#4686)
  Translated using Weblate (Dutch)
  Translated using Weblate (French)
  Translated using Weblate (Spanish)
  Bump marked from 11.2.0 to 12.0.0 (FreeTubeApp#4638)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot