Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sass-loader from 14.2.1 to 16.0.0 #5495

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 29, 2024

Bumps sass-loader from 14.2.1 to 16.0.0.

Release notes

Sourced from sass-loader's releases.

v16.0.0

16.0.0 (2024-07-26)

⚠ BREAKING CHANGES

  • use modern Sass JS API by default for sass and sass-embedded

[!WARNING]

The sass options are different for the legacy (before) and modern APIs. Please look at docs how to migrate to the modern options. Legacy options - https://sass-lang.com/documentation/js-api/interfaces/legacystringoptions/ Modern options - https://sass-lang.com/documentation/js-api/interfaces/options/

To return to the previous logic use:

module.exports = {
  module: {
    rules: [
      {
        test: /\.s[ac]ss$/i,
        use: [
          "style-loader",
          "css-loader",
          {
            loader: "sass-loader",
            options: {
              api: "legacy",
              // Your options
            },
          },
        ],
      },
    ],
  },
};

Features

  • use modern Sass JS API by default for sass and sass-embedded (10be1ba)

v15.0.0

⚠ BREAKING CHANGES

  • prefer sass-embedded over sass by default (#1211)

Features

... (truncated)

Changelog

Sourced from sass-loader's changelog.

16.0.0 (2024-07-26)

⚠ BREAKING CHANGES

  • use modern Sass JS API by default for sass and sass-embedded

[!WARNING]

The sass options are different for the legacy (before) and modern APIs. Please look at docs how to migrate to the modern options. Legacy options - https://sass-lang.com/documentation/js-api/interfaces/legacystringoptions/ Modern options - https://sass-lang.com/documentation/js-api/interfaces/options/

To return to the previous logic use:

module.exports = {
  module: {
    rules: [
      {
        test: /\.s[ac]ss$/i,
        use: [
          "style-loader",
          "css-loader",
          {
            loader: "sass-loader",
            options: {
              api: "legacy",
              // Your options
            },
          },
        ],
      },
    ],
  },
};

Features

  • use modern Sass JS API by default for sass and sass-embedded (10be1ba)

15.0.0 (2024-07-23)

⚠ BREAKING CHANGES

  • prefer sass-embedded over sass by default (#1211)

Features

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 14.2.1 to 16.0.0.
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases)
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/v16.0.0/CHANGELOG.md)
- [Commits](webpack-contrib/sass-loader@v14.2.1...v16.0.0)

---
updated-dependencies:
- dependency-name: sass-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 29, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 29, 2024 09:02
@efb4f5ff-1298-471a-8973-3d47447115dc

Breaking changes dont affect us?

@PikachuEXE
Copy link
Collaborator

From https://www.npmjs.com/package/sass-embedded

This package is an alternative to the sass package. It supports the same JS API as sass and is maintained by the same team, but where the sass package is pure JavaScript, sass-embedded is instead a JavaScript wrapper around a native Dart executable.

No error = fine by me

16.0 = JS API I don't think we use it directly so the same

@FreeTubeBot FreeTubeBot merged commit b9ee595 into development Aug 2, 2024
6 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/sass-loader-16.0.0 branch August 2, 2024 15:09
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 2, 2024
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 4, 2024
* development:
  Bump version number to v0.21.3
  Bump sass-loader from 14.2.1 to 16.0.0 (FreeTubeApp#5495)
  ^ Update youtubei.js (FreeTubeApp#5507)
  Use streams from the iOS client to workaround playback issues (FreeTubeApp#5472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants