Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YouTube.js 10.3.0 #5507

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Aug 1, 2024

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

Include fix in LuanRT/YouTube.js#713 released in https://github.com/LuanRT/YouTube.js/releases/tag/v10.3.0

Screenshots

Nope

Testing

  • Watch video w/ local API = no error

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 1, 2024 10:06
@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 1, 2024
@absidue absidue changed the title Update youtubei.js Update YouTube.js 10.3.0 Aug 1, 2024
@absidue
Copy link
Member

absidue commented Aug 1, 2024

Edited the pull request body to point to the pull request that actually fixed the problem.

@PikachuEXE
Copy link
Collaborator Author

I totally cannot understand that PR~

@efb4f5ff-1298-471a-8973-3d47447115dc

I totally cannot understand that PR~

I think its time for Ash to evolve you👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

#5472 needs to be merged after this one though

@PikachuEXE
Copy link
Collaborator Author

Added #5502 to PR body

@absidue are you testing or just forgot to approve

@absidue
Copy link
Member

absidue commented Aug 1, 2024

I totally cannot understand that PR~

Instead of using regex to find and extract the deciphering functions from YouTube's player JavaScript, it now uses a JavaScript parser and then searches through the parsed stuff instead. The idea being that the parsed stuff has a more standard/predictable structure so it should be a bit more robust.

@FreeTubeBot FreeTubeBot merged commit 42837c8 into FreeTubeApp:development Aug 1, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 1, 2024
@PikachuEXE PikachuEXE deleted the update/youtubejs branch August 1, 2024 12:50
OothecaPickle pushed a commit to OothecaPickle/FreeTube that referenced this pull request Aug 1, 2024
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 4, 2024
* development:
  Bump version number to v0.21.3
  Bump sass-loader from 14.2.1 to 16.0.0 (FreeTubeApp#5495)
  ^ Update youtubei.js (FreeTubeApp#5507)
  Use streams from the iOS client to workaround playback issues (FreeTubeApp#5472)
absidue pushed a commit to absidue/FreeTube that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Local API Error: Failed to extract n-token decipher algorithm
5 participants