Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartographer probe config #581

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

xyleth
Copy link

@xyleth xyleth commented Apr 18, 2024

This is an attempt to add the Cartographer eddy sensor probe to Klippain in the same style as the Beacon probe.

This config is tested and works on my Voron 2.4r2 300mm.

Copy link
Collaborator

@Surion79 Surion79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for completeness, please add the the cartographer.conf for moonraker update manager to the moonraker folder and the include line in the moonraker.conf file. thanks :) Otherwise it is good

@@ -106,6 +106,9 @@

## Beacon probe also used as virtual Z endstop. Do not forget to install the plugin and add the [beacon] section to make it work!
# [include config/hardware/probes/beacon_virtual.cfg]

## Cartographer probe also used as virtual Z endstop. Do not forget to install the plugin and add the [cartographer] section to make it work!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would precise it here (i know it is not done in beacon), and write to add a cartographer section to the overrides.

@Surion79 Surion79 changed the base branch from main to develop April 18, 2024 15:30
@Surion79
Copy link
Collaborator

@xyleth
Copy link
Author

xyleth commented Apr 18, 2024

Added as requested in latest commit.

Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

@Surion79 Surion79 added the tracking This issue is tracked and work will be done label May 31, 2024
@nbaer89
Copy link

nbaer89 commented Jun 4, 2024

Just want to add, I implemented this into my install and I get an error due to the [safe_z_home] section. I had to remove it to get it to work, but that leaves me having to be careful about where my probe is when z-homing as it can occur off the bed and cause serious problems.

@Tecnologic
Copy link

Hi, any progress here? I have a Cartographer in my Micron+ and would like to give this a try. What do u suggest is the best way? Just checkout the pull request?

@Surion79
Copy link
Collaborator

@xyleth could you please update your branch so we can attempt a merge?
Thanks

@Surion79 Surion79 requested a review from Frix-x June 21, 2024 16:17
@Surion79 Surion79 linked an issue Jun 21, 2024 that may be closed by this pull request
@xyleth
Copy link
Author

xyleth commented Jun 21, 2024 via email

@Tecnologic
Copy link

hi xyleth, i tryed ur changes with my config but have a conflict with sensorless homing cause u define safe home z with ur configs. "homing_override and safe_z_homing cannot be used simultaneously". so if i remove the safe_home z, there is another error "Unknown pin chip name 'cartographer'" according to carto trouble shooting its releated to the order of definition and usage of the carto in the config. i assume its the lis2dw pin because its gone when i remove the include for the carto lis2dw. After that u face the error Unknown pin chip name 'probe' error which is again releated to config order of definition and usage.

I'm willing to help with this but unsure how i can help. i dont think that another pull request with my changes is the appropriate way to have this working.

@xyleth
Copy link
Author

xyleth commented Jul 3, 2024

Hi!

Hmm, I recently changed to sensorless homing and it works fine, but to be honest I've forgotten what it was I had to change to make it work! My printer has been out of action due to extruder issues so I haven't looked at it for a while.

realistically it is going to be next week sometime before I can sit down and focus on getting this sorted, work and other commitments have tied up all my time between now and then. I can see that the PR needs to be updated to be against the most recent release of the Klippain code and then re-submitted.

@Tecnologic
Copy link

I just manually added the line of the pull so maybe I made a mistake there. Should have time in evening to just switch to Ur branch and test locally on my machine.

My time is limited to so don't mind. But 2 persons with limited time is more than one:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking This issue is tracked and work will be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for cartographer3d probe
4 participants