Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: group connectors between native and external #271

Merged
merged 28 commits into from
Sep 23, 2024
Merged

feat: group connectors between native and external #271

merged 28 commits into from
Sep 23, 2024

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Sep 20, 2024 •
edited
Loading

Closes #262

  • Group connectors between native and external

CleanShot 2024-09-20 at 21 35 55

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 5:49pm

@arthurgeron arthurgeron changed the title feat: group connectors feat: group connectors between native and external Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.3% 141 / 230
🔵 Statements 61.3% 141 / 230
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/fuel-wallet/src/FuelWalletConnector.ts 59.17% 86.36% 56.66% 59.17% 69-76, 80-85, 87, 91, 95-96, 99-100, 103-110, 113-114, 117-124, 127-131, 134-143, 151-152, 156-161, 223-224, 230-247, 287-294
Generated in workflow #713

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 16 / 16
🔵 Statements 100% 16 / 16
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #713

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #713

@arthurgeron arthurgeron marked this pull request as draft September 21, 2024 00:01
@arthurgeron arthurgeron marked this pull request as ready for review September 21, 2024 00:37
helciofranco
helciofranco previously approved these changes Sep 23, 2024
View reviewed changes
@arthurgeron arthurgeron changed the base branch from main to ls/feat/add-disclaimer September 23, 2024 15:41
@arthurgeron arthurgeron force-pushed the ag/feat/group-connectors branch from 866607e to 8ecd221 Compare September 23, 2024 17:01
Base automatically changed from ls/feat/add-disclaimer to main September 23, 2024 17:48
@arthurgeron arthurgeron dismissed helciofranco’s stale review September 23, 2024 17:48

The base branch was changed.

@arthurgeron arthurgeron enabled auto-merge (squash) September 23, 2024 17:50
@arthurgeron arthurgeron merged commit 366ffa9 into main Sep 23, 2024
10 checks passed
@arthurgeron arthurgeron deleted the ag/feat/group-connectors branch September 23, 2024 18:35
@fuel-service-user fuel-service-user mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@helciofranco helciofranco helciofranco approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connectors list - separate by sections
4 participants
@arthurgeron @luizstacio @helciofranco @LuizAsFight