Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importer/CM integration #887

Closed
2 tasks
Voxelot opened this issue Jan 5, 2023 · 1 comment · Fixed by #903 or #915
Closed
2 tasks

Importer/CM integration #887

Voxelot opened this issue Jan 5, 2023 · 1 comment · Fixed by #903 or #915
Assignees
@xgreenx

Comments

@Voxelot
Copy link
Member

Voxelot commented Jan 5, 2023

  • Implement importer related ports from the PoA service for the importer adapter in fuel-core.
  • Provide the importer adapter to the PoA service during initialization in FuelService.
@Voxelot
Copy link
Member Author

Voxelot commented Jan 5, 2023

depends on: #883, #884

@Voxelot Voxelot mentioned this issue Jan 5, 2023
Closed
@xgreenx xgreenx self-assigned this Jan 16, 2023
@Voxelot Voxelot linked a pull request Jan 16, 2023 that will close this issue
Implementation of the block importer #903
Merged
@xgreenx xgreenx mentioned this issue Jan 18, 2023
Merged
@xgreenx xgreenx reopened this Jan 20, 2023
freesig added a commit that referenced this issue Jan 23, 2023
@xgreenx @freesig
@ControlCplusControlV @Voxelot
Connect the block importer with outside world (#915)
9037d3a 
- Closes #887
- Closes #884

What is done:

- Removed `CHAIN_HEIGHT_KEY`, because now we have a genesis block to
track this information.
- Unified all database API that works with `BlockHeight` to work with
references. Previously in some places, it was the reference, in some
not.
- Added `manual_produce_block` into `PoA` and used it in the `GraphQL`
to have the one source of the block production. There are no unit
tests(help is appreciated).
- Connected `PoA` and `BlockImporter` via ports. Added
`BlockImporterAdapter`.
- Added the `FuelBlockRoots` column with the corresponding table. It is
used to track BMT MMR roots for fuel blocks. The implementation adds new
`DatabaseColumn` and `IntoDatabaseKey` traits to automate the storage
trait implementation for some tables.
- Moved implementation of database ports into the corresponding file in
the `fuel_core::service::adapter`.
- Removed the `Database` generic from `PoA` at all. Now we must pass the
`last_height` while creating the `Task`. Updated tests to work with it.
- Block producer now accepts the `block_time` along with `block_height`.

Co-authored-by: Tom <tomrgowan@gmail.com>
Co-authored-by: ControlCplusControlV <44706811+ControlCplusControlV@users.noreply.github.com>
Co-authored-by: Voxelot <brandonkite92@gmail.com>
crypto523 pushed a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
@freesig @ControlCplusControlV @Voxelot
Connect the block importer with outside world (#915)
ae3ae01 
- Closes FuelLabs/fuel-core#887
- Closes FuelLabs/fuel-core#884

What is done:

- Removed `CHAIN_HEIGHT_KEY`, because now we have a genesis block to
track this information.
- Unified all database API that works with `BlockHeight` to work with
references. Previously in some places, it was the reference, in some
not.
- Added `manual_produce_block` into `PoA` and used it in the `GraphQL`
to have the one source of the block production. There are no unit
tests(help is appreciated).
- Connected `PoA` and `BlockImporter` via ports. Added
`BlockImporterAdapter`.
- Added the `FuelBlockRoots` column with the corresponding table. It is
used to track BMT MMR roots for fuel blocks. The implementation adds new
`DatabaseColumn` and `IntoDatabaseKey` traits to automate the storage
trait implementation for some tables.
- Moved implementation of database ports into the corresponding file in
the `fuel_core::service::adapter`.
- Removed the `Database` generic from `PoA` at all. Now we must pass the
`last_height` while creating the `Task`. Updated tests to work with it.
- Block producer now accepts the `block_time` along with `block_height`.

Co-authored-by: Tom <tomrgowan@gmail.com>
Co-authored-by: ControlCplusControlV <44706811+ControlCplusControlV@users.noreply.github.com>
Co-authored-by: Voxelot <brandonkite92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Voxelot @xgreenx