Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.17.8 #1096

Closed
wants to merge 4 commits into from
Closed

Release 0.17.8 #1096

wants to merge 4 commits into from

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Apr 2, 2023

Yet another hotfix.. In my local testing it seems like jemalloc has less overhead when initializing vm instances (which we do frequently). It should also do a better job of reclaiming memory.

The release also disables dap endpoints for the production.

@Voxelot Voxelot requested a review from xgreenx April 2, 2023 06:58
It is a separate change from
#1096 to create an image
without `jemallocator` not to mix fixes.

Do not merge it. Maybe we will combine it with `jemallocator` for the
release.
@xgreenx xgreenx marked this pull request as ready for review April 4, 2023 16:57
Update all deps.
Remove `?` from `rocksdb`.
@xgreenx xgreenx changed the title Release/0.17.8 Release 0.17.8 Apr 4, 2023
xgreenx
xgreenx previously approved these changes Apr 4, 2023
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the change in the DEV net. Sentry-1(blue) had 0.17.8(with this change) and Sentry-3(red) had 0.17.7(without this change).

I spammed each node two times with one million of dry_runs (simple transfer transactions). After each spam, I did a small pause to allow the node to rest.

The jemalloc shows much better memory management. It used less memory during each run, after the end of each spamming attack the memory almost normalized.

image

image

@Voxelot Voxelot changed the base branch from release/0.17.7 to master April 5, 2023 01:48
@Voxelot Voxelot dismissed xgreenx’s stale review April 5, 2023 01:48

The base branch was changed.

@Voxelot Voxelot changed the base branch from master to release/0.17.7 April 5, 2023 01:48
Voxelot pushed a commit that referenced this pull request Apr 5, 2023
It is a separate change from
#1096 to create an image
without `jemallocator` not to mix fixes.

Do not merge it. Maybe we will combine it with `jemallocator` for the
release.
@Voxelot Voxelot mentioned this pull request Apr 5, 2023
@Voxelot
Copy link
Member Author

Voxelot commented Apr 5, 2023

This has been released already, and the changes have been ported to land on master in #1102

@Voxelot Voxelot closed this Apr 5, 2023
Voxelot added a commit that referenced this pull request Apr 5, 2023
Merges the changes from #1096
upstream into master

---------

Co-authored-by: Green Baneling <xgreenx9999@gmail.com>
crypto523 pushed a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
Merges the changes from FuelLabs/fuel-core#1096
upstream into master

---------

Co-authored-by: Green Baneling <xgreenx9999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants