Disable dap for the production fuel-core-bin
#1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
approved these changes
Apr 4, 2023
| default = ["debug", "metrics", "rocksdb"] | ||
| metrics = ["dep:fuel-core-metrics"] | ||
| p2p = ["dep:fuel-core-p2p", "dep:fuel-core-sync"] | ||
| relayer = ["dep:fuel-core-relayer"] | ||
| rocksdb = ["dep:rocksdb", "dep:tempfile"] | ||
| test-helpers = ["fuel-core-p2p?/test-helpers"] | ||
| # features to enable in production, but increase build times | ||
| rocksdb-production = ["rocksdb?/jemalloc"] | ||
| rocksdb-production = ["rocksdb", "rocksdb?/jemalloc"] |
There was a problem hiding this comment.
nit: shouldn't this be just "rocksdb/jemalloc", not conditonal on rocksdb since we explicitly enable it already?
Voxelot
pushed a commit
that referenced
this pull request
Apr 5, 2023
It is a separate change from #1096 to create an image without `jemallocator` not to mix fixes. Do not merge it. Maybe we will combine it with `jemallocator` for the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a separate change from #1096 to create an image without
jemallocatornot to mix fixes.Do not merge it. Maybe we will combine it with
jemallocatorfor the release.