-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for refactored fuel-asm, fuel-vm 0.26.0 #973
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
previously approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
8 tasks
mitchmindtree
added a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 7, 2023
This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream, this unblocks the associated sway update PR here: FuelLabs/sway#4004.
mitchmindtree
added a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 7, 2023
This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream, this unblocks the associated sway update PR here: FuelLabs/sway#4004.
mitchmindtree
added a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 7, 2023
This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream, this unblocks the associated sway update PR here: FuelLabs/sway#4004.
mitchmindtree
added a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 7, 2023
This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream, this unblocks the associated sway update PR here: FuelLabs/sway#4004.
This is needed now as the vm changes has been merged |
Waiting for the |
Dentosal
changed the title
Update for refactored fuel-asm
Update for refactored fuel-asm, fuel-vm 0.26.0
Feb 7, 2023
Voxelot
approved these changes
Feb 7, 2023
mitchmindtree
added a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 8, 2023
….26. (#827) This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The aim is to propagate this last API-breaking update through fuels-rs and sway before beta-3. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream and the [patch] table is removed in this PR, this unblocks the associated sway update PR here: FuelLabs/sway#4004. --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Voxelot
added a commit
to FuelLabs/sway
that referenced
this pull request
Feb 8, 2023
…, `fuel-core` -> `0.17`. (#4004) NOTE: This PR is against @Voxelot's PR branch here: #3961. This updates all crates for the recent upstream `fuel-asm` refactor. To learn more about the refactor, see the original PR at the fuel-vm repo: FuelLabs/fuel-vm#283. The fuel-core update PR can be found here: FuelLabs/fuel-core#973. ## TODO - [x] Update `fuels` for `fuel-asm` change. `fuels-core` errors in the `offsets` module. Will address this now and then update this PR. ## Follow-up - [Rename `AllocatedOpcode` to `AllocatedInstruction` to follow fuel-spec/fuel-asm terminology.](#4006) ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: bingcicle <bingcicle@proton.me> Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
MujkicA
pushed a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 8, 2023
….26. (#827) This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The aim is to propagate this last API-breaking update through fuels-rs and sway before beta-3. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream and the [patch] table is removed in this PR, this unblocks the associated sway update PR here: FuelLabs/sway#4004. --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
MujkicA
pushed a commit
to FuelLabs/fuels-rs
that referenced
this pull request
Feb 10, 2023
….26. (#827) This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The aim is to propagate this last API-breaking update through fuels-rs and sway before beta-3. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream and the [patch] table is removed in this PR, this unblocks the associated sway update PR here: FuelLabs/sway#4004. --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
ak-tech007
added a commit
to ak-tech007/Rust-SDK
that referenced
this pull request
Dec 6, 2024
….26. (#827) This updates all crates for the `fuel-asm` refactor introduced here: FuelLabs/fuel-vm#283. You can learn more about the change at this PR. The aim is to propagate this last API-breaking update through fuels-rs and sway before beta-3. The associated fuel-core PR can be found here: FuelLabs/fuel-core#973. Once the refactor lands upstream and the [patch] table is removed in this PR, this unblocks the associated sway update PR here: FuelLabs/sway#4004. --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks FuelLabs/fuel-vm#283Updates to fuel-vm 0.26.0