Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all crates for recent fuel-asm refactor. fuel-vm -> 0.26, fuel-core -> 0.17. #4004

Merged
merged 13 commits into from
Feb 8, 2023
Merged

Update all crates for recent fuel-asm refactor. fuel-vm -> 0.26, fuel-core -> 0.17. #4004

merged 13 commits into from
Feb 8, 2023

Conversation

mitchmindtree
Copy link
Contributor

@mitchmindtree mitchmindtree commented Feb 7, 2023 •
edited
Loading

NOTE: This PR is against @Voxelot's PR branch here: #3961.

This updates all crates for the recent upstream fuel-asm refactor.

To learn more about the refactor, see the original PR at the fuel-vm repo: FuelLabs/fuel-vm#283.

The fuel-core update PR can be found here: FuelLabs/fuel-core#973.

TODO

  • Update fuels for fuel-asm change. fuels-core errors in the offsets module. Will address this now and then update this PR.

Follow-up

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@mitchmindtree mitchmindtree added compiler General compiler. Should eventually become more specific as the issue is triaged forc compiler: codegen Everything to do with IR->ASM, register allocation, etc. labels Feb 7, 2023
@mitchmindtree mitchmindtree requested review from otrho, Voxelot and a team February 7, 2023 04:49
@mitchmindtree mitchmindtree self-assigned this Feb 7, 2023
mitchmindtree added a commit to FuelLabs/fuels-rs that referenced this pull request Feb 7, 2023
@mitchmindtree
Update for pending fuel-asm refactor
4651afb 
This updates all crates for the `fuel-asm` refactor introduced here:
FuelLabs/fuel-vm#283. You can learn more about the change at this PR.

The associated fuel-core PR can be found here:
FuelLabs/fuel-core#973.

Once the refactor lands upstream, this unblocks the associated sway
update PR here: FuelLabs/sway#4004.
mitchmindtree added a commit to FuelLabs/fuels-rs that referenced this pull request Feb 7, 2023
@mitchmindtree
Update for pending fuel-asm refactor
796ef6a 
This updates all crates for the `fuel-asm` refactor introduced here:
FuelLabs/fuel-vm#283. You can learn more about the change at this PR.

The associated fuel-core PR can be found here:
FuelLabs/fuel-core#973.

Once the refactor lands upstream, this unblocks the associated sway
update PR here: FuelLabs/sway#4004.
mitchmindtree added a commit to FuelLabs/fuels-rs that referenced this pull request Feb 7, 2023
@mitchmindtree
Update for pending fuel-asm refactor
a81fe00 
This updates all crates for the `fuel-asm` refactor introduced here:
FuelLabs/fuel-vm#283. You can learn more about the change at this PR.

The associated fuel-core PR can be found here:
FuelLabs/fuel-core#973.

Once the refactor lands upstream, this unblocks the associated sway
update PR here: FuelLabs/sway#4004.
@mitchmindtree mitchmindtree mentioned this pull request Feb 7, 2023
Merged
mitchmindtree added a commit to FuelLabs/fuels-rs that referenced this pull request Feb 7, 2023
@mitchmindtree
Update for pending fuel-asm refactor
ced8d16 
This updates all crates for the `fuel-asm` refactor introduced here:
FuelLabs/fuel-vm#283. You can learn more about the change at this PR.

The associated fuel-core PR can be found here:
FuelLabs/fuel-core#973.

Once the refactor lands upstream, this unblocks the associated sway
update PR here: FuelLabs/sway#4004.
@mitchmindtree mitchmindtree mentioned this pull request Feb 7, 2023
Open
eightfilms and others added 4 commits February 7, 2023 16:22
@eightfilms
remove branch from fuel deps since they are merged
247bded
@mitchmindtree
Add an extra mdbook build step in attempt to get readable output
e31b877 
The mdbook forc documenter step currently dumps output to a file, so we
can't see what actually went wrong, only that something did.

This adds a clone of this step to see if we can see the output.

Also removes unnecessary ERROR log check from doc reference, as it does
not use the mdbook-forc-documenter plugin at all.
@mitchmindtree
Merge branch 'mitchmindtree/fuel-asm-refactor-ci-tweaks' into mitchmi…
2fd3cfd 
…ndtree/fuel-asm-refactor
@mitchmindtree
Update to fuel-core 0.17, fuel-vm 0.26
863ee07
@mitchmindtree mitchmindtree changed the title Update all crates for recent fuel-asm refactor. Bump fuel-vm crates to 0.25.3. Update all crates for recent fuel-asm refactor. fuel-vm -> 0.26, fuel-core -> 0.17. Feb 8, 2023
mitchmindtree added a commit to FuelLabs/fuels-rs that referenced this pull request Feb 8, 2023
@mitchmindtree @Voxelot
Update for fuel-asm refactor. Updates for fuel-core 0.17, fuel-vm 0…
fc5c7be 
….26. (#827)

This updates all crates for the `fuel-asm` refactor introduced here:
FuelLabs/fuel-vm#283. You can learn more about the change at this PR.
The aim is to propagate this last API-breaking update through fuels-rs
and sway before beta-3.

The associated fuel-core PR can be found here: FuelLabs/fuel-core#973.

Once the refactor lands upstream and the [patch] table is removed in
this PR, this unblocks the associated sway update PR here:
FuelLabs/sway#4004.

---------

Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
@mitchmindtree mitchmindtree marked this pull request as ready for review February 8, 2023 06:53
@Voxelot Voxelot merged commit 8f4d6ca into Voxelot/update-predicate-metadata-0.33.1 Feb 8, 2023
@Voxelot Voxelot deleted the mitchmindtree/fuel-asm-refactor branch February 8, 2023 07:27
MujkicA pushed a commit to FuelLabs/fuels-rs that referenced this pull request Feb 8, 2023
@mitchmindtree @Voxelot @MujkicA
Update for fuel-asm refactor. Updates for fuel-core 0.17, fuel-vm 0…
70d5be0 
….26. (#827)

This updates all crates for the `fuel-asm` refactor introduced here:
FuelLabs/fuel-vm#283. You can learn more about the change at this PR.
The aim is to propagate this last API-breaking update through fuels-rs
and sway before beta-3.

The associated fuel-core PR can be found here: FuelLabs/fuel-core#973.

Once the refactor lands upstream and the [patch] table is removed in
this PR, this unblocks the associated sway update PR here:
FuelLabs/sway#4004.

---------

Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
MujkicA pushed a commit to FuelLabs/fuels-rs that referenced this pull request Feb 10, 2023
@mitchmindtree @Voxelot @MujkicA
Update for fuel-asm refactor. Updates for fuel-core 0.17, fuel-vm 0…
b8f2968 
….26. (#827)

This updates all crates for the `fuel-asm` refactor introduced here:
FuelLabs/fuel-vm#283. You can learn more about the change at this PR.
The aim is to propagate this last API-breaking update through fuels-rs
and sway before beta-3.

The associated fuel-core PR can be found here: FuelLabs/fuel-core#973.

Once the refactor lands upstream and the [patch] table is removed in
this PR, this unblocks the associated sway update PR here:
FuelLabs/sway#4004.

---------

Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
ak-tech007 added a commit to ak-tech007/Rust-SDK that referenced this pull request Dec 6, 2024
@ak-tech007 @Voxelot
Update for fuel-asm refactor. Updates for fuel-core 0.17, fuel-vm 0…
b97b141 
….26. (#827)

This updates all crates for the `fuel-asm` refactor introduced here:
FuelLabs/fuel-vm#283. You can learn more about the change at this PR.
The aim is to propagate this last API-breaking update through fuels-rs
and sway before beta-3.

The associated fuel-core PR can be found here: FuelLabs/fuel-core#973.

Once the refactor lands upstream and the [patch] table is removed in
this PR, this unblocks the associated sway update PR here:
FuelLabs/sway#4004.

---------

Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otrho otrho Awaiting requested review from otrho

@Voxelot Voxelot Awaiting requested review from Voxelot

Assignees

@mitchmindtree mitchmindtree

Labels
compiler: codegen Everything to do with IR->ASM, register allocation, etc. compiler General compiler. Should eventually become more specific as the issue is triaged forc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchmindtree @Voxelot @eightfilms