-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates ABI spec with hash based ids, versions and program type. #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
force-pushed
the
esdrubal/hash-based-ids
branch
2 times, most recently
from
July 1, 2024 09:36
c24411e
to
3bcae64
Compare
Adds specification for how hashes based ids are generated from a string representation of types. Updates `json-abi-format.md` with versions, program type, and hash based ids.
esdrubal
force-pushed
the
esdrubal/hash-based-ids
branch
from
July 1, 2024 09:43
3bcae64
to
3b673f5
Compare
esdrubal
added a commit
to FuelLabs/fuel-abi-types
that referenced
this pull request
Jul 4, 2024
Implements changes as specified in: FuelLabs/fuel-specs#596 Adds specVersion, abiVersion and programType to ProgramABI. Updates TypeDeclaration to use a String in type_id.
arboleya
reviewed
Jul 4, 2024
nedsalk
reviewed
Jul 4, 2024
esdrubal
force-pushed
the
esdrubal/hash-based-ids
branch
from
July 9, 2024 11:44
0fe02e2
to
a426b32
Compare
IGI-111
pushed a commit
to FuelLabs/fuel-abi-types
that referenced
this pull request
Jul 9, 2024
Implements changes as specified in: FuelLabs/fuel-specs#596 Adds specVersion, abiVersion and programType to ProgramABI. Updates TypeDeclaration to use a String in type_id.
4 tasks
esdrubal
force-pushed
the
esdrubal/hash-based-ids
branch
from
July 12, 2024 12:52
a8f786f
to
952f8bd
Compare
arboleya
approved these changes
Jul 12, 2024
IGI-111
approved these changes
Jul 13, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5151
#5952
#5954
Adds specification for how hashes based ids are generated from a string representation of types.
Updates
json-abi-format.md
with versions, program type, and hash based ids.Before requesting review
After merging, notify other teams
[Add or remove entries as needed]