Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ABI spec with hash based ids, versions and program type. #596

Merged
merged 6 commits into from
Jul 13, 2024

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Jul 1, 2024

#5151
#5952
#5954

Adds specification for how hashes based ids are generated from a string representation of types.

Updates json-abi-format.md with versions, program type, and hash based ids.

Before requesting review

  • I have reviewed the code myself

After merging, notify other teams

[Add or remove entries as needed]

@esdrubal esdrubal added the ABI Contract ABI label Jul 1, 2024
@esdrubal esdrubal self-assigned this Jul 1, 2024
@esdrubal esdrubal force-pushed the esdrubal/hash-based-ids branch 2 times, most recently from c24411e to 3bcae64 Compare July 1, 2024 09:36
esdrubal added 2 commits July 1, 2024 10:41
Adds specification for how hashes based ids are generated from a string
representation of types.

Updates `json-abi-format.md` with versions, program type, and hash based ids.
@esdrubal esdrubal force-pushed the esdrubal/hash-based-ids branch from 3bcae64 to 3b673f5 Compare July 1, 2024 09:43
@esdrubal esdrubal requested review from a team July 1, 2024 09:44
esdrubal added a commit to FuelLabs/fuel-abi-types that referenced this pull request Jul 4, 2024
Implements changes as specified in: FuelLabs/fuel-specs#596

Adds specVersion, abiVersion and programType to ProgramABI.
Updates TypeDeclaration to use a String in type_id.
src/abi/json-abi-format.md Outdated Show resolved Hide resolved
src/abi/json-abi-format.md Outdated Show resolved Hide resolved
@arboleya arboleya requested a review from nedsalk July 4, 2024 11:39
@esdrubal esdrubal force-pushed the esdrubal/hash-based-ids branch from 0fe02e2 to a426b32 Compare July 9, 2024 11:44
IGI-111 pushed a commit to FuelLabs/fuel-abi-types that referenced this pull request Jul 9, 2024
Implements changes as specified in:
FuelLabs/fuel-specs#596

Adds specVersion, abiVersion and programType to ProgramABI. Updates
TypeDeclaration to use a String in type_id.
@esdrubal esdrubal force-pushed the esdrubal/hash-based-ids branch from a8f786f to 952f8bd Compare July 12, 2024 12:52
@IGI-111 IGI-111 merged commit 63844b5 into master Jul 13, 2024
6 checks passed
@IGI-111 IGI-111 deleted the esdrubal/hash-based-ids branch July 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI Contract ABI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants