Fixed json deserialization of array fuel types from the file #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
xgreenx
changed the title
xgreenx
reviewed
Nov 28, 2023
fuel-types/src/array_types.rs
Outdated
| @@ -334,7 +334,7 @@ macro_rules! key_methods { | |||
| { | |||
| use serde::de::Error; | |||
| if deserializer.is_human_readable() { | |||
| let s: &str = serde::Deserialize::deserialize(deserializer)?; | |||
| let s: String = serde::Deserialize::deserialize(deserializer)?; | |||
There was a problem hiding this comment.
Deserialization from the file for the &str type returns an error because getting a reference to the memory is impossible.
xgreenx
previously approved these changes
Nov 28, 2023
xgreenx
approved these changes
Nov 28, 2023
Merged
sdankel
added a commit
to FuelLabs/sway
that referenced
this pull request
Nov 29, 2023
## Description Closes #2010 Notes: - I couldn't use `from_reader` to deserialize the file contents due to this issue: FuelLabs/fuel-vm#643 ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.