-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.44.0 #659
Release 0.44.0 #659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that the last change to serialization will not make the performance worse? Could you run simple benchmarks, please?=)
Plus we can remove BytesVisitor
. Plus there is a bug with bincode
serialization into the file, so maybe you also want to fix it=) It is how fix looks locally for BytesVisitor
What bug are we talking about? A performance bug? |
No, deserialization bug like here but for I think the same test with bincode should fail and the change on the screen fixes the issue |
I ran some benchmarks, and this is a performance regression. Sadly, there seems to be no way to avoid this if we want to get rid of the extra byte on We can revert here, but that means having to work around the extra byte in places where we'd rather have the performance penalty than the size penalty. BenchmarksBeforebincode Bytes32 [31.612 ns 31.707 ns 31.805 ns] Afterbincode Bytes32 [101.29 ns 101.40 ns 101.50 ns] |
Ok seems like it was a bad nightly version for benchmarking:
|
Version v0.44.0
Changed
ECAL
opcode handler can now hold internal state.Breaking
key!
-generated types likeAddress
,AssetId
,ContractId
andBytes32
consume one less byte when serialized with a binary serde serializer like postcard.What's Changed
Full Changelog: v0.43.2...v0.44.0