Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: read cargo toml instead of running cargo metadata #1552

Merged
merged 1 commit into from
Dec 5, 2024
Merged

bug: read cargo toml instead of running cargo metadata #1552

merged 1 commit into from
Dec 5, 2024

Conversation

segfault-magnet
Copy link
Contributor

Summary

Now we read from the Cargo.toml and use that for the CI check. More details in the issue.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@segfault-magnet segfault-magnet self-assigned this Dec 5, 2024
@segfault-magnet segfault-magnet merged commit 08771d9 into master Dec 5, 2024
45 checks passed
@segfault-magnet segfault-magnet deleted the bug/fuel_core_version_check_fix branch December 5, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hal3e hal3e hal3e approved these changes

@MujkicA MujkicA MujkicA approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

Assignees

@segfault-magnet segfault-magnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

patch release breaks fuel core version compatibility check
4 participants
@segfault-magnet @Salka1988 @MujkicA @hal3e