-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: merge fuels-types
and fuels-core
#956
Conversation
fuels-types
and fuels-core
fuels-types
and fuels-core
Haven't reviewed yet, but I suggest we hold off on this PR until #950 is merged because it's more pressing than this tech debt. I should push the corrections to the PR today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, seems good.
Waiting for the fuels types reexports to remove redundancy in the import path.
IIRC we agreed that was to be done here. If not ping me and I'll approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I'd give up on the idea of shortening the reexport path since even the std does it like we do (e.g. std::result::Result
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice reorg, feels much cleaner now 🧹
Please make sure to include precise instructions on how to migrate the exports for the user, and include it in a BREAKING CHANGE
footer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful — ship it!
closes: #945 - modules `utils` and `types::core` and `types::wrappers` are not exposed. They are used for code organization. - `traits` are moved to `fuels-core` - breaking! - `codec` is now used to get to `ABIEncoder`, `ABIDecoder`, `try_from_bytes` and `resolve_fn_selector` - breaking! - exposed `fuels_core::types` only through `fuels::types`
closes: #945 - modules `utils` and `types::core` and `types::wrappers` are not exposed. They are used for code organization. - `traits` are moved to `fuels-core` - breaking! - `codec` is now used to get to `ABIEncoder`, `ABIDecoder`, `try_from_bytes` and `resolve_fn_selector` - breaking! - exposed `fuels_core::types` only through `fuels::types`
closes: #945
fuels-types
is merged intofuels-core
. This is the new structure:utils
andtypes::core
andtypes::wrappers
are not exposed. They are used for code organization.traits
are moved tofuels-core
- breaking!codec
is now used to get toABIEncoder
,ABIDecoder
,try_from_bytes
andresolve_fn_selector
- breaking!fuels_core::types
only throughfuels::types
Checklist