-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: reexport lost fuels::tx::Output under fuels::types::output::Output #961
bug: reexport lost fuels::tx::Output under fuels::types::output::Output #961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not fuels::types::{Input, Output}
directly? It would be released with the big changes from #950 anyway so it would make sense IMO.
I'd love to, but then we'd have to also do all of these as well: pub mod bech32;
pub mod block;
pub mod chain_info;
pub mod coin;
pub mod constants;
pub mod enum_variants;
pub mod errors;
pub mod input;
pub mod message;
pub mod message_proof;
pub mod node_info;
pub mod offsets;
pub mod param_types;
pub mod resource;
pub mod traits;
pub mod transaction;
pub mod transaction_builders;
pub mod transaction_response;
pub mod unresolved_bytes; make them private mods and reexport their contents publicly. So I wanted to suggest the idea here before doing it. If the @FuelLabs/sdk-rust is ok with it lets do it. |
Ah yes no ok this is much larger haha, warrants a discussion |
I like this idea. I suggest we do it in #956 as I am already introducing breaking changes there with re-exports. |
We've recently lost our
fuels::tx::Output
reexport of thefuel_tx::Output
, this PR introduces it back but under a less surprising location (fuels::types::output::Output
to mimic the already existingfuels::types::input::Input
)Although I'm not a fan of the
output::Output
verbosity, I decided to leave it so that it doesn't surprise users.We should probably reexport the types under
fuels::types::{Input, Output}
rather than needlessly mention the internal mod structure.Checklist