-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Turbo cache in CI #1753
Comments
FWIW, it seems that the error happens when re-running a failed workflow. We should stress test this case if we re-add the work reverted by #1752. The failing workflow is something like this: Job 1
Job 2
So if we have inconsistencies between cache hits/misses with the GH cache, and the turbo package caches - it will fail. Most commonly it seems to be |
Ah okay this is good information. A similar implementation to work reverted in #1752 may suffice then, as long as it accounts for the failed stage. Unsure why at the moment though, I'd expect the cache entries to still be present and it would still run using the same SHA. |
In #1649 we introduced a Turbo cache in CI, however it was prone to flakiness. As the
docs
build is dependent on an autogenerated file fromproviders
, ifproviders
hits the cache but docs misses, the job will fail.Adding a build cache would improve the time of the second job in our test CI, so we should look to introduce it. However something that is more robust than what was added in #1649, #1694 and #1721.
The text was updated successfully, but these errors were encountered: