Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add generated file cache to CI #1694

Merged
merged 9 commits into from
Jan 31, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Jan 30, 2024

Resolves this CI error.

docs is not hitting the cache as one of the cache inputs is generated on build. We should therefore also cache generated files to ensure cache validity is correctly checked.

Cache executed here.

@danielbate danielbate added the chore Issue is a chore label Jan 30, 2024
@danielbate danielbate added this to the 2 - Beetle milestone Jan 30, 2024
@danielbate danielbate self-assigned this Jan 30, 2024
@danielbate danielbate marked this pull request as ready for review January 30, 2024 09:10
@petertonysmith94
Copy link
Contributor

Suggest passing through the cache-path as input arguments.

@danielbate
Copy link
Contributor Author

@petertonysmith94 please can you provide an example? And what's the benefit of this?

@petertonysmith94
Copy link
Contributor

Hey @danielbate,
I suppose for me only having to update 2 places, rather than 4 is worth it.

This is a untested test commit, was only a suggestion :)
b284d42

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
78.63%(+0%) 68.64%(+0%) 76.65%(+0%) 78.59%(+0%)
Changed Files:

Coverage values did not change👌.

Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

@danielbate danielbate merged commit af66671 into master Jan 31, 2024
17 checks passed
@danielbate danielbate deleted the db/chore/add-generated-file-ci-cache branch January 31, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants