Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix generated restore cache in CI #1721

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Feb 6, 2024

Closes #1717

We should not be saving the cache before building, otherwise the cache entry will not contain the files generated during build.

@danielbate danielbate self-assigned this Feb 6, 2024
@danielbate danielbate added bug Issue is a bug chore Issue is a chore labels Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Coverage Report:

Lines Branches Functions Statements
78.46%(+0%) 68.5%(+0%) 76.65%(+0%) 78.42%(+0%)
Changed Files:

Coverage values did not change👌.

@danielbate danielbate marked this pull request as ready for review February 6, 2024 10:10
@danielbate danielbate enabled auto-merge (squash) February 6, 2024 10:27
@danielbate danielbate merged commit 20a8e0f into master Feb 6, 2024
27 checks passed
@danielbate danielbate deleted the db/chore/fix-generated-restore-cache branch February 6, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify flaky CI Setup workflow
3 participants