Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: infra to use typegen in tests #2123

Merged
merged 35 commits into from
May 16, 2024
Merged

build: infra to use typegen in tests #2123

merged 35 commits into from
May 16, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Apr 19, 2024 •
edited
Loading

This PR introduces infrastructure for running typegen in our internal test suite.

closes #2070

@nedsalk nedsalk added the chore Issue is a chore label Apr 19, 2024
@nedsalk nedsalk self-assigned this Apr 19, 2024
nedsalk and others added 20 commits April 19, 2024 12:55
@nedsalk @petertonysmith94
Update packages/abi-typegen/src/abi/types/EnumType.ts
19296ca 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
@nedsalk
fix: missing import
8d1c794
@nedsalk
test: verify that () type is generated properly
0311379
@nedsalk
Merge branch 'ns/feat/support-empty-sway-type-in-typegen' into ns/cho…
d51ea3a 
…re/use-typegen-in-tests
@nedsalk
fix: teeing
73f3527
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/chore/use-typege…
767ee40 
…n-in-tests
@nedsalk
feat: ignore empty function inputs
65c6661
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/chore/use-typege…
e3e9e2a 
…n-in-tests
@nedsalk
Merge branch 'ns/feat/support-empty-sway-type-in-typegen' into ns/cho…
4b8e740 
…re/use-typegen-in-tests
@nedsalk
test: added tests covering various empty param use cases
cf9b651
@nedsalk
Merge branch 'ns/feat/support-empty-sway-type-in-typegen' into ns/cho…
f721e5b 
…re/use-typegen-in-tests
@nedsalk
fix: rename to correct fn name
1d9b7d4
@nedsalk
Merge branch 'ns/feat/support-empty-sway-type-in-typegen' into ns/cho…
4a2adcc 
…re/use-typegen-in-tests
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/support-emp…
62dcfde 
…ty-sway-type-in-typegen
@nedsalk
Merge branch 'ns/feat/support-empty-sway-type-in-typegen' into ns/cho…
68b3e39 
…re/use-typegen-in-tests
@nedsalk
Merge branch 'master' into ns/feat/support-empty-sway-type-in-typegen
e05cb8a
@nedsalk
fix: better explanation
ed6b155
@nedsalk
Merge branch 'ns/feat/support-empty-sway-type-in-typegen' into ns/cho…
4aacbf9 
…re/use-typegen-in-tests
@nedsalk
Merge branch 'master' into ns/feat/support-empty-sway-type-in-typegen
4eaa5e2
@nedsalk
Merge remote-tracking branch 'origin/ns/feat/support-empty-sway-type-…
85c9b1e 
…in-typegen' into ns/chore/use-typegen-in-tests
nedsalk
nedsalk commented Apr 23, 2024
View reviewed changes
scripts/forc-build-with-typegen.sh Outdated Show resolved Hide resolved
scripts/forc-build-with-typegen.sh Outdated Show resolved Hide resolved
@maschad maschad changed the title chore: infra to use typegen in tests build: infra to use typegen in tests Apr 23, 2024
maschad
maschad previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, left some suggestions.

.changeset/honest-zoos-cough.md Show resolved Hide resolved
scripts/forc-build-with-typegen.sh Outdated Show resolved Hide resolved
@nedsalk @maschad
Update scripts/forc-build-with-typegen.sh
1485d33 
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
@nedsalk nedsalk requested a review from maschad April 23, 2024 18:29
maschad
maschad previously approved these changes Apr 23, 2024
View reviewed changes
arboleya
arboleya previously requested changes Apr 23, 2024
View reviewed changes
.eslintrc.js Show resolved Hide resolved
scripts/forc-build-with-typegen.sh Outdated Show resolved Hide resolved
scripts/forc-build-with-typegen.sh Outdated Show resolved Hide resolved
@arboleya arboleya mentioned this pull request Apr 23, 2024
Merged
@nedsalk nedsalk marked this pull request as draft April 24, 2024 08:32
@danielbate danielbate mentioned this pull request May 15, 2024
Closed
@nedsalk nedsalk requested review from arboleya and maschad May 15, 2024 16:10
@nedsalk nedsalk marked this pull request as ready for review May 15, 2024 16:12
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.79%(+0.25%) 70.47%(+0.63%) 76.85%(-0.27%) 79.88%(+0.23%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/AbiCoder.ts 75%
(+0%)		 0%
(-100%)		 66.66%
(+0%)		 75%
(+0%)
🔴 packages/abi-coder/src/FunctionFragment.ts 65.38%
(-4.18%)		 60%
(-9.69%)		 71.42%
(-1.91%)		 64.81%
(-4.63%)
🔴 packages/abi-coder/src/Interface.ts 72%
(+0%)		 60%
(-2.5%)		 76.92%
(+0%)		 71.42%
(+0%)
✅ ✨ packages/abi-coder/src/encoding/coders/ArrayCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/B256Coder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/B512Coder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/BigNumberCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/BooleanCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/ByteCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/EnumCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/NumberCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/OptionCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 ✨ packages/abi-coder/src/encoding/coders/RawSliceCoder.ts 94.44%
(+94.44%)		 83.33%
(+83.33%)		 100%
(+100%)		 94.44%
(+94.44%)
✅ ✨ packages/abi-coder/src/encoding/coders/StdStringCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StrSliceCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StringCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StructCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/TupleCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/VecCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 packages/abi-coder/src/encoding/strategies/getCoderV1.ts 91.48%
(-0.18%)		 86.66%
(+0%)		 100%
(+0%)		 91.66%
(+0%)
🔴 packages/abi-coder/src/utils/constants.ts 97.36%
(-0.07%)		 100%
(+0%)		 0%
(+0%)		 97.36%
(-0.07%)
🔴 packages/abi-coder/src/utils/utilities.ts 20%
(-76.49%)		 0%
(-80%)		 50%
(-50%)		 27.27%
(-69.45%)
🔴 packages/account/src/account.ts 82.78%
(-0.22%)		 66.66%
(+0%)		 76%
(+0%)		 82.35%
(-0.23%)
🔴 packages/account/src/mnemonic/utils.ts 97.61%
(+19.15%)		 91.66%
(+28.03%)		 100%
(+0%)		 97.77%
(+18.06%)
🔴 packages/account/src/predicate/predicate.ts 24.19%
(+1.81%)		 31.25%
(+0%)		 13.33%
(+0.83%)		 23.07%
(+1.65%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 85.91%
(+0.4%)		 75%
(+2.17%)		 86%
(-0.53%)		 86.3%
(+0.4%)
🔴 packages/account/src/providers/transaction-summary/call.ts 6.25%
(+1.49%)		 0%
(+0%)		 0%
(+0%)		 6.25%
(+1.49%)
🔴 packages/create-fuels/src/cli.ts 87.8%
(-0.43%)		 60.52%
(+0%)		 100%
(+0%)		 88.23%
(-0.4%)
✅ ✨ packages/create-fuels/src/lib/setupProgram.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 packages/program/src/contract-call-script.ts 10.97%
(+0.14%)		 0%
(+0%)		 0%
(+0%)		 10.58%
(+0.02%)
🔴 packages/program/src/functions/multicall-scope.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/utils/src/utils/toUtf8Bytes.ts 88%
(+88%)		 84.61%
(+84.61%)		 100%
(+100%)		 88.46%
(+88.46%)
🔴 ✨ packages/utils/src/utils/toUtf8String.ts 94.64%
(+94.64%)		 92.3%
(+92.3%)		 100%
(+100%)		 94.73%
(+94.73%)

@nedsalk nedsalk dismissed arboleya’s stale review May 16, 2024 07:23

Addressed comments

@nedsalk nedsalk enabled auto-merge (squash) May 16, 2024 07:23
danielbate
danielbate approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

@nedsalk nedsalk merged commit 6d4c869 into master May 16, 2024
19 checks passed
@nedsalk nedsalk deleted the ns/chore/use-typegen-in-tests branch May 16, 2024 07:30
@danielbate danielbate mentioned this pull request May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create infrastructure for using typegen in integration tests
5 participants
@nedsalk @arboleya @danielbate @maschad @petertonysmith94