chore: add browser testing to fuel-gauge
#2319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
reviewed
May 16, 2024
| { | ||
| stdio: 'pipe', | ||
| if (process.env.VITEST && process.env.VITEST_ENV !== 'browser') { | ||
| const { spawn } = await import('child_process'); |
There was a problem hiding this comment.
Does this mean that tests running in the browser won't need a polyfill for this this import? If so, cool stuff!
…/FuelLabs/fuels-ts into db/chore/fuel-gauge-browser-test
…/chore/fuel-gauge-browser-test
|
Superseded by work in #2378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #284
Builds on #2123 to utilise typegen in tests, meaning we require less polyfilled/reimplemented functionality.
child_processcan't be polyfilled, so I am now dynamically importing it in a non-browser environment. This has made version related functionalityasync. This is likely to not be a problem ifaccountwas tree-shakeable.