Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support configurable constants contracts #991

Merged
merged 20 commits into from
May 10, 2023
Merged

feat: support configurable constants contracts #991

merged 20 commits into from
May 10, 2023

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf added the feat Issue is a feature label May 9, 2023
@Torres-ssf Torres-ssf self-assigned this May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
95.37% (-0.01% 🔻)
 4800/5033
🟢 Branches
83.94% (-0.1% 🔻)
 836/996
🟢 Functions
92.86% (+0.04% 🔼)
 924/995
🟢 Lines
95.38% (-0.02% 🔻)
 4578/4800
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / contract-factory.ts
87.04% (+0.55% 🔼)
62.5% (-4.17% 🔻)
87.5% (+4.17% 🔼)
87.04% (+0.55% 🔼)

Test suite run success

851 tests passing in 135 suites.

Report generated by 🧪jest coverage report action from 3225465

@Torres-ssf Torres-ssf marked this pull request as ready for review May 10, 2023 01:24
arboleya
arboleya approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. 🤯

arboleya
arboleya previously approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. 🤯

digorithm

This comment was marked as resolved.

Sign in to view

@Torres-ssf Torres-ssf requested review from digorithm and arboleya May 10, 2023 17:09
camsjams
camsjams approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ⚡ :shipit:

@Torres-ssf Torres-ssf merged commit eda13d7 into master May 10, 2023
@Torres-ssf Torres-ssf deleted the st/feat/support-configurable-constants-contracts branch May 10, 2023 22:39
@github-actions github-actions bot mentioned this pull request May 10, 2023
Merged
This was referenced May 11, 2023
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsjams camsjams camsjams approved these changes

@arboleya arboleya arboleya approved these changes

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure-time constants
4 participants
@Torres-ssf @arboleya @camsjams @digorithm