Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forc-deploy should use forc-wallet to create a new wallet vault #4754

Closed
kayagokalp opened this issue Jul 6, 2023 · 0 comments · Fixed by #4827
Closed

forc-deploy should use forc-wallet to create a new wallet vault #4754

kayagokalp opened this issue Jul 6, 2023 · 0 comments · Fixed by #4827
Assignees
@kayagokalp
Labels
enhancement New feature or request forc-deploy Everything to do with forc-deploy

Comments

@kayagokalp
Copy link
Member

raised here: #4752 (comment)
@kayagokalp kayagokalp added enhancement New feature or request forc-deploy Everything to do with forc-deploy labels Jul 6, 2023
This was referenced Jul 6, 2023
Merged
Closed
@kayagokalp kayagokalp self-assigned this Jul 18, 2023
@kayagokalp kayagokalp mentioned this issue Jul 19, 2023
Merged
kayagokalp added a commit that referenced this issue Jul 23, 2023
@kayagokalp
feat: forc-deploy suggests creating a new wallet if the wallet is mis…
c3d75e7 
…sing (#4827)

## Description
closes #4754.

If the default path does not contain any wallet, forc-deploy
automatically suggests creating a new one via forc-wallet:

```console
Could not find a wallet at "/Users/kayagokalp/.fuel/wallets/.wallet", would you like to create a new one? [y/N]: y
Please enter a password to encrypt this private key: 
Please confirm your password: 
Wallet created successfully.
```
At this step a new window opens with your mnemonic just like
forc-wallet's new flow. User pres enter:
```console
Please provide the password of your encrypted wallet vault at "/Users/kayagokalp/.fuel/wallets/.wallet":
Do you accept to sign this transaction with fuel13pudgkhq9pmsj3s2nwxmsmydqnau3lcpn5m70jrg5mrw0dlc3r8qz6pjdk? [y/N]: y
```

User is asked for their password again, to prevent this I need to cut
another release to forc-wallet which is currently blocked. So I will fix
that in a follow-up PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-deploy Everything to do with forc-deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: forc-deploy suggests creating a new wallet if the wallet is missing FuelLabs/sway
1 participant
@kayagokalp