-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate forc-wallet and forc-deploy #4752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Also will keep this waiting, won't merge right away because I need a release for fuel.nix stuff with #4750 merged. I want to omit releasing a version with this (before updating the UX). So my current plan looks like:
So that if anything comes up (very bad bugs with this etc) we do not block fuel.nix resolutions any longer, and have a release that both works for fuel.nix and without this changes. |
Instead of typing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving just for admin reasons (two reviews needed) as this was already approved before and just had a merge conflict fixed.
Description
closes #4743.
This PR integrates forc-wallet and forc-deploy together so that forc-deploy can offer to sign your transactions without running a second terminal window. Below there are some inputs and outputs after this change.
forc-deploy --random-salt
At this point if the user enters wrong password:
If the user enters correct password:
If the user enters
y
orY
and hits enter:If the user enters anything else:
Checklist
Breaking*
orNew Feature
labels where relevant.