Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make --random-salt default to forc-deploy and remove it as a flag #4760

Merged
merged 4 commits into from
Jul 7, 2023
Merged

feat: make --random-salt default to forc-deploy and remove it as a flag #4760

merged 4 commits into from
Jul 7, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Jul 6, 2023 •
edited
Loading

Description

closes #4758.

This PR makes --random-salt the default behaviour of forc-deploy, if salt information is passed, the passed salt would be used but otherwise, random-salt would be implied by default. Also adds --default-salt for CI so that in CI we can always create the same contract id if we want to. Useful for reproducible deployments.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp changed the title feat: feat: make --random-salt default to forc-deploy and remove it as a flag Jul 6, 2023
@kayagokalp kayagokalp added enhancement New feature or request blocked forc-deploy Everything to do with forc-deploy labels Jul 6, 2023
@kayagokalp kayagokalp self-assigned this Jul 6, 2023
@kayagokalp
Copy link
Member Author

Waiting on #4752.

@kayagokalp kayagokalp removed the blocked label Jul 6, 2023
@kayagokalp kayagokalp marked this pull request as ready for review July 6, 2023 13:15
@kayagokalp kayagokalp requested a review from a team July 6, 2023 13:15
JoshuaBatty
JoshuaBatty reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one spelling mistake otherwise happy to approve

forc-plugins/forc-client/src/cmd/deploy.rs Outdated Show resolved Hide resolved
@kayagokalp @JoshuaBatty
Update forc-plugins/forc-client/src/cmd/deploy.rs
3f61fee 
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
@kayagokalp kayagokalp requested review from a team and JoshuaBatty July 6, 2023 13:55
JoshuaBatty
JoshuaBatty approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kayagokalp kayagokalp enabled auto-merge (squash) July 6, 2023 13:58
@JoshuaBatty JoshuaBatty requested a review from a team July 6, 2023 13:58
@kayagokalp kayagokalp mentioned this pull request Jul 6, 2023
Merged
7 tasks
@JoshuaBatty JoshuaBatty requested a review from a team July 6, 2023 23:43
@kayagokalp kayagokalp merged commit d8ee8a2 into master Jul 7, 2023
@kayagokalp kayagokalp deleted the kayagokalp/4758 branch July 7, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eureka-cpu eureka-cpu eureka-cpu approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-deploy Everything to do with forc-deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forc-deploy should have --random-salt by default
3 participants
@kayagokalp @JoshuaBatty @eureka-cpu