Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forc-fmt panics #5006

Closed
sdankel opened this issue Aug 23, 2023 · 0 comments · Fixed by #5051
Closed

forc-fmt panics #5006

sdankel opened this issue Aug 23, 2023 · 0 comments · Fixed by #5051
Assignees

Comments

@sdankel
Copy link
Member

sdankel commented Aug 23, 2023

There are a number of input files that cause the formatter panic, which it should never do. One example: test/src/e2e_vm_tests/test_programs/should_fail/abi_associated_const_access/src/main.sw

It should always exit cleanly, with user-friendly error messages if it was unable to format the file.

To identify all the scenarios that cause it to panic, we should run it against all of the test programs in sway. This will help identify panics as well as potential bugs, since the unit test suite in swayfmt is far from comprehensive.

@sdankel sdankel self-assigned this Aug 23, 2023
sdankel added a commit that referenced this issue Aug 29, 2023
## Description

Closes #5006

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant