Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forc-fmt panic when file cannot be lexed #5010

Closed
sdankel opened this issue Aug 24, 2023 · 1 comment · Fixed by #5011
Closed

forc-fmt panic when file cannot be lexed #5010

sdankel opened this issue Aug 24, 2023 · 1 comment · Fixed by #5011
Assignees
@sdankel
Labels
bug Something isn't working formatter

Comments

@sdankel
Copy link
Member

sdankel commented Aug 24, 2023 

forc-fmt test/src/e2e_vm_tests/test_programs/should_fail/u256/src/main.sw

This results in a panic. Even though the file isn't valid sway, the formatter should exit cleanly.
@sdankel sdankel self-assigned this Aug 24, 2023
@sdankel sdankel added bug Something isn't working formatter labels Aug 24, 2023
@sdankel
Copy link
Member Author

sdankel commented Aug 24, 2023

Related #5006

@sdankel sdankel mentioned this issue Aug 24, 2023
Merged
7 tasks
sdankel added a commit that referenced this issue Aug 25, 2023
@sdankel
Fix forc-fmt panic when lexing fails (#5011)
985e055 
## Description

Closes #5010

Now instead of a panic, the user sees this: 

<img width="836" alt="image"
src="https://github.com/FuelLabs/sway/assets/47993817/2da2e075-8a10-4ed4-8892-1c95cc42af63">

With debug logging they can see the compiler error, or they can simply
run the compiler.

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdankel sdankel

Labels
bug Something isn't working formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix forc-fmt panic when lexing fails FuelLabs/sway
1 participant
@sdankel