Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert and rethink starting node with forc run #770

Closed
adlerjohn opened this issue Feb 10, 2022 · 0 comments · Fixed by #786
Closed

Revert and rethink starting node with forc run #770

adlerjohn opened this issue Feb 10, 2022 · 0 comments · Fixed by #786
Assignees
Labels
forc good first issue Good for newcomers

Comments

@adlerjohn
Copy link
Contributor

Revert the changes from #270 that start a node forc run. The issue with the current setup is that it will start a node with a persistent on-disk db, then not close it by default. Which then makes running a script multiple times (which always happens due to testing) not really produce desired results. It also makes it opaque how to then shut down the node gracefully later.

This should then be replaced by a long documentation blob if a node cannot be found at the given (or default) URL when running forc run and forc deploy.

We need to rethink exactly how, if it all, we want forc to start nodes. My suspicion is that any starting of nodes within forc will lead to more issues than not, and good errors are strictly better than opaque behavior with side effects.

@adlerjohn adlerjohn added good first issue Good for newcomers forc labels Feb 10, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network Feb 10, 2022
@adlerjohn adlerjohn self-assigned this Feb 13, 2022
Repository owner moved this from Todo to Done in Fuel Network Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forc good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant