Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start fuel-client node on forc-run if no node is started at a given url #270

Merged
merged 4 commits into from
Sep 30, 2021
Merged

Start fuel-client node on forc-run if no node is started at a given url #270

merged 4 commits into from
Sep 30, 2021

Conversation

leviathanbeak
Copy link
Contributor

this is the second (and the final) part of #246 ,

in this PR, we implement following:

  • 2 extra command arguments for forc-run with option to read env vars
  • option to start a client node if not started
  • option to kill the node that was started by forc-run, by default the node is left alive after the process ends

@leviathanbeak leviathanbeak self-assigned this Sep 27, 2021
@adlerjohn adlerjohn requested a review from digorithm September 27, 2021 13:37
@adlerjohn adlerjohn added the enhancement New feature or request label Sep 30, 2021
@leviathanbeak leviathanbeak merged commit 2908193 into master Sep 30, 2021
@leviathanbeak leviathanbeak deleted the leviathanbeak/246_part_two_start_the_node branch September 30, 2021 15:35
@adlerjohn adlerjohn linked an issue Oct 31, 2021 that may be closed by this pull request
on forc run add the option for user to start a node if it's not already running #246
Closed
@adlerjohn adlerjohn mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@sezna sezna Awaiting requested review from sezna

@digorithm digorithm Awaiting requested review from digorithm

Assignees

@leviathanbeak leviathanbeak

Labels
enhancement New feature or request forc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

on forc run add the option for user to start a node if it's not already running
2 participants
@leviathanbeak @adlerjohn