Descriptive error instead of allowing starting a node with forc run
#786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
requested review from
JoshuaBatty,
digorithm,
mitchmindtree and
sezna
digorithm
approved these changes
Feb 13, 2022
mitchmindtree
approved these changes
Feb 13, 2022
There was a problem hiding this comment.
Nice, I think it's a good choice to more clearly distinguish between responsibilities of forc and fuel-core like this. Maybe once both have matured a bit we can consider a dedicated optional flag that spins up a temp fuel-core for the duration of forc run or something along those lines.
| @@ -38,6 +38,11 @@ impl CliError { | |||
| ); | |||
| Self { message } | |||
| } | |||
|
|
|||
| pub fn fuel_core_not_running(node_url: &str) -> Self { | |||
| let message = format!("could not get a response from node at the URL {}. Start a node with `fuel-core`. See <https://github.com/FuelLabs/fuel-core#running> for more information", node_url); | |||
There was a problem hiding this comment.
I'm surprised rustfmt doesn't try and wrap this or break the format! args onto different lines, but if rustfmt's happy I'm happy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770