Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug referencing const declarations in other modules. #301

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

otrho
Copy link
Contributor

@otrho otrho commented Oct 11, 2021

Caveat, line 1239 in mod.rs:

    // NOTE: this is currently flattening out the entire namespace, which is problematic.  To fix
    // it we need to support hierarchical names (or at least absolute normalised names) to
    // AsmNamespace.  This can be done in the new ASM generator which translates from IR, coming
    // soon.

Closes #297.

@otrho otrho requested review from sezna and emilyaherbert October 11, 2021 03:41
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sezna sezna merged commit fec6001 into master Oct 11, 2021
@sezna sezna deleted the otrho/297_public_constants branch October 11, 2021 18:10
@Voxelot Voxelot mentioned this pull request Jan 23, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

constants exported from libraries cause internal compiler errors
2 participants