Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use const for ETH_COLOR in test case #303

Merged
merged 2 commits into from
Oct 12, 2021
Merged

use const for ETH_COLOR in test case #303

merged 2 commits into from
Oct 12, 2021

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Oct 11, 2021

Now that #301 is in, we can use the ETH_COLOR const here and remove the references to the bug report.

@sezna sezna added the compiler General compiler. Should eventually become more specific as the issue is triaged label Oct 11, 2021
@sezna sezna self-assigned this Oct 11, 2021
@adlerjohn
Copy link
Contributor

Is CI supposed to fail now?

@sezna sezna merged commit f56b49b into master Oct 12, 2021
@sezna sezna deleted the sezna/use_const branch October 12, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@otrho otrho Awaiting requested review from otrho

@emilyaherbert emilyaherbert Awaiting requested review from emilyaherbert

Assignees

@sezna sezna

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sezna @adlerjohn