Fixes issue with generic trait impls using the same method names. #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
bug
esdrubal
force-pushed
the
duplicate_def_3633
branch
from
2cfa494 to
89a0a97
Compare
|
Upon further investigation, #3633 isn't a bug after all, but instead a matter of showing the user a bad error message. Apologies for adding this additional context after have submitted this PR 😭 I'm going to close this PR and remove your assignment from #3633 for bookkeeping, but please feel free to re-add your assignment to #3633 if you'd like to continue working on that GH issue. |
emilyaherbert
suggested changes
Jan 6, 2023
emilyaherbert
suggested changes
Jan 13, 2023
esdrubal
force-pushed
the
duplicate_def_3633
branch
from
89a0a97 to
a930f01
Compare
emilyaherbert
suggested changes
Jan 17, 2023
When two generic trait implementation use the same method implementation an error such as `Duplicate definition for method "convert" for type "A"` would occur. This fix does remove the error when a method with diferent type parameters is added to another trait implementation with different type parameters. The fix also ensures that find_method_for_type returns a method whose parameters types matches the given arguments expressions return types. Closes FuelLabs#3633.
esdrubal
force-pushed
the
duplicate_def_3633
branch
from
e1fbb3e to
4154540
Compare
nfurfaro
previously approved these changes
Jan 26, 2023
emilyaherbert
suggested changes
Jan 26, 2023
|
(I wrote a review comment but it's showing up under the fold of a previous resolved comment. CC @esdrubal) |
emilyaherbert
suggested changes
Jan 27, 2023
emilyaherbert
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
This looks really good @esdrubal 🎉 I appreciate your persistence with this PR through the re-review process.
mohammadfawaz
approved these changes
Feb 3, 2023
eightfilms
pushed a commit
that referenced
this pull request
Feb 7, 2023
) When two generic trait implementation use the same method name with a different type parameter an error such as `Duplicate definition for method "convert" for type "A"` would occur. This fix does remove the error when a method with diferent type parameters is added to another trait implementation with different type parameters. The fix also ensures that when possible find_method_for_type returns a method whose parameters types matches the given arguments expressions return types. Closes #3633. --------- Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two generic trait implementation use the same method name with a different type parameter an error such as
Duplicate definition for method "convert" for type "A"would occur.This fix does remove the error when a method with diferent type parameters is added to another trait implementation with different type parameters.
The fix also ensures that when possible find_method_for_type returns a method whose parameters types matches the given arguments expressions return types.
Closes #3633.