Implement From trait for u64 for U128 & U256 #4581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
reviewed
May 23, 2023
anton-trunov
suggested changes
Jul 13, 2023
Comment on lines
+43
to
+45
| fn into(self) -> u64 { | ||
| self.as_u64().unwrap() | ||
| } |
There was a problem hiding this comment.
Here, into may fail, but the Rust semantics says that the From/Into trait methods must not fail (see https://doc.rust-lang.org/std/convert/trait.From.html).
Comment on lines
+65
to
+67
| fn into(self) -> u64 { | ||
| self.as_u64().unwrap() | ||
| } |
There was a problem hiding this comment.
Here, into may fail, but the Rust semantics says that the From/Into trait methods must not fail (see https://doc.rust-lang.org/std/convert/trait.From.html).
|
Superceded by #4829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple helper functions for easy conversion between big integers and
u64.Checklist
Breaking*orNew Featurelabels where relevant.