Numeric type inference #4829
Merged
Numeric type inference #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
added
lib: std
IGI-111
force-pushed
the
IGI-111/numeric-inference
branch
3 times, most recently
from
9156842 to
8143ce9
Compare
test/src/e2e_vm_tests/test_programs/should_fail/binop_intrinsics/test.toml
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/language/numeric_constants/src/main.sw
Show resolved
Hide resolved
This does two things. 1. Integer types no longer automatically cast to each other. Methods such as `as_u64` and `try_as_u8` have been introduced to require the user to explicit the cast. Warnings about casts losing precision have been removed as they are no longer possible. 2. Numeric literals (such as `32` without further qualifications) no longer immediately decay to a `u64` and we instead attempt to type them as `TypeInfo::Numeric` as far as possible to allow their usage with any integer type. Numeric intrinsics unify arguments with the numeric type to enforce their constraints. Numeric values are forced to decay to `u64` when resolving methods or traits. This change is a prerequisite to move our representation of sub-byte-sized values to a different memory representation, as numeric types need to be distinct if we are ever to treat them differently.
IGI-111
force-pushed
the
IGI-111/numeric-inference
branch
from
8143ce9 to
69e8154
Compare
anton-trunov
approved these changes
Jul 20, 2023
JoshuaBatty
approved these changes
Jul 21, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This does two things.
Integer types no longer automatically cast to each other. Methods such as
as_u64andtry_as_u8have been introduced to require the user to explicit the cast.Warnings about casts losing precision have been removed as they are no longer possible.
Numeric literals (such as
32without further qualifications) no longer immediately decay to au64and we instead attempt to type them asTypeInfo::Numericas far as possible to allow their usage with any integer type.Numeric intrinsics unify arguments with the numeric type to enforce their constraints.
Numeric values are forced to decay to
u64when resolving methods or traits.This change is a prerequisite to move our representation of sub-byte-sized values to a different memory representation, as numeric types need to be distinct if we are ever to treat them differently.
Fixes #3470
Checklist
Breaking*orNew Featurelabels where relevant.