-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GTF_OUTPUT_COIN_ASSET_ID
and GTF_OUTPUT_COIN_TO
opcode getters
#4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Braqzen
reviewed
Jun 20, 2023
K1-R1
reviewed
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem fine, but CI is failing
bitzoic
added
the
breaking
May cause existing user code to break. Requires a minor or major release.
label
Jun 22, 2023
K1-R1
previously approved these changes
Jun 22, 2023
Braqzen
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In the setup the wallet transfers 2 assets. Do we need to transfer the second asset to the predicate prior to testing or can that transfer be removed?
- When unpacking variables from the setup function in the tests I would use the same variable names throughout instead of sometimes using
wallet
and thenwallet1
etc.
|
|
|
Braqzen
approved these changes
Jun 22, 2023
SwayStar123
approved these changes
Jun 22, 2023
7 tasks
dmihal
added a commit
that referenced
this pull request
May 17, 2024
## Description When `output_asset_to` was added in #4694, it used `b256` as the return type, instead of an `Address`. It referenced #4569, which describes the confusion developers face between `Address` and `Identity`. While that confusion _is_ an issue, I don't believe that's relevant to this function type. An output coin can _only_ be an address, not a contract, since contract balances are stored in the contract UTXO itself. Furthermore, the standard lib API will need to be frozen soon, and there's no plans in place to change anything in regards to #4569. ## Checklist - [ ] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: SwayStar123 <46050679+SwayStar123@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
May cause existing user code to break. Requires a minor or major release.
enhancement
New feature or request
lib: std
Standard library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added getters for the
GTF_OUTPUT_COIN_ASSET_ID
andGTF_OUTPUT_COIN_TO
opcodes. These have been highly requested by external teams for use in predicates.Note: The
output_asset_to()
getter currently returns ab256
rather than anIdentity
. This should be updated when #4569 is resolved.Checklist
Breaking*
orNew Feature
labels where relevant.