-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return type of output_asset_to changed to Address #5424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitzoic
previously approved these changes
Dec 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me! Also very cool to see our first practical implementation of order-independent modules since #5300 has been merged 🔥
SwayStar123
reviewed
Dec 29, 2023
dmihal
force-pushed
the
dm/output_asset_to-address
branch
from
May 14, 2024 13:49
e11543d
to
1d488c0
Compare
SwayStar123
approved these changes
May 15, 2024
bitzoic
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K1-R1
approved these changes
May 17, 2024
bitzoic
added
breaking
May cause existing user code to break. Requires a minor or major release.
lib: std
Standard library
labels
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
output_asset_to
was added in #4694, it usedb256
as the return type, instead of anAddress
. It referenced #4569, which describes the confusion developers face betweenAddress
andIdentity
.While that confusion is an issue, I don't believe that's relevant to this function type. An output coin can only be an address, not a contract, since contract balances are stored in the contract UTXO itself. Furthermore, the standard lib API will need to be frozen soon, and there's no plans in place to change anything in regards to #4569.
Checklist
Breaking*
orNew Feature
labels where relevant.