Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that entry block does not have predecessors #6177

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Jun 24, 2024

Description

This PR fixes #6148 by verifying that a function entry block cannot have predecessors.

Additionally, the PR provides a simple testing infrastructure for testing IR verifications.

Closes #6148.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev self-assigned this Jun 24, 2024
@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: ir IRgen and sway-ir including optimization passes labels Jun 24, 2024
@ironcev ironcev marked this pull request as ready for review June 24, 2024 15:22
@ironcev ironcev requested a review from a team as a code owner June 24, 2024 15:22
@ironcev ironcev requested a review from a team June 24, 2024 15:22
@ironcev ironcev enabled auto-merge (squash) June 24, 2024 16:37
@ironcev ironcev requested a review from a team June 24, 2024 16:37
@ironcev ironcev merged commit edebc4d into master Jun 24, 2024
37 checks passed
@ironcev ironcev deleted the ironcev/6148-entry-blocks-in-IR branch June 24, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: ir IRgen and sway-ir including optimization passes compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loops involving entry block are not properly handled.
3 participants