FSI fixes #360
Merged
FSI fixes #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Igor/fsi fixes
Merge pull request #355 from idkakorin/igor/FSIFixes
Igor/fsi fixes
Add last changes
Igor/fsi fixes
|
Reopen pull request. |
Merge pull request #15 from GENIE-MC/igor/FSIFixes
idkakorin
requested review from
candreop,
nusense,
sjgardiner,
dytman and
jtenavidal
restore functionality of NucBindEnergyAggregator
Igor/fsi fixes
Merge with current master
fix warnings: Unused class rule
…configuration error
Igor/fsi fixes
idkakorin
approved these changes
Dec 11, 2023
|
This was discussed at the Core Dev meeting on 11 Dec 2023, and despite weird things noticed by Igor in the order of the particles, this PR fixes a number of issue that restore correct operations with the model. Hence we go on with merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.