-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: GEOS paper submittal to JOSS #2886
Conversation
hi @rrsettgast ! Why not in its own repository, with its own CI, with its own PRs ? |
Submission requirements The software must be open source as per the OSI definition. |
Whaou! Ok thanks for the explanation ! |
No problem. Thanks for the question. |
src/docs/JOSS/MeshHierarchy.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should update this figure because some things have changed since when it was made (e.g., the FaceElementRegion
, FaceElementSubRegion
,...). How was it generated in the first place? I am happy to generate an updated one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @TotoGaz generated this...but perhaps this figure is not required for the paper...and it can just be updated in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generated on the fly from src/coreComponents/mesh/docs/MeshObjectInstantiationHierarchy.plantuml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Randy, a couple typos in the names
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2886 +/- ##
===========================================
- Coverage 56.59% 56.31% -0.29%
===========================================
Files 1064 1065 +1
Lines 89766 90227 +461
===========================================
Hits 50807 50807
- Misses 38959 39420 +461 ☔ View full report in Codecov by Sentry. |
No description provided.