Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: GEOS paper submittal to JOSS #2886

Closed
wants to merge 166 commits into from
Closed

docs: GEOS paper submittal to JOSS #2886

wants to merge 166 commits into from

Conversation

rrsettgast
Copy link
Member

No description provided.

@untereiner
Copy link
Contributor

hi @rrsettgast ! Why not in its own repository, with its own CI, with its own PRs ?

@rrsettgast
Copy link
Member Author

hi @rrsettgast ! Why not in its own repository, with its own CI, with its own PRs ?

Submission requirements

The software must be open source as per the OSI definition.
The software must be hosted at a location where users can open issues and propose code changes without manual approval of (or payment for) accounts.
The software must have an obvious research application.
You must be a major contributor to the software you are submitting, and have a GitHub account to participate in the review process.
Your paper must not focus on new research results accomplished with the software.
Your paper (paper.md and BibTeX files, plus any figures) must be hosted in a Git-based repository together with your software (although they may be in a short-lived branch which is never merged with the default).

https://joss.readthedocs.io/en/latest/submitting.html

@untereiner
Copy link
Contributor

Whaou! Ok thanks for the explanation !

@rrsettgast
Copy link
Member Author

No problem. Thanks for the question.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update this figure because some things have changed since when it was made (e.g., the FaceElementRegion, FaceElementSubRegion,...). How was it generated in the first place? I am happy to generate an updated one.

Copy link
Member Author

@rrsettgast rrsettgast Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @TotoGaz generated this...but perhaps this figure is not required for the paper...and it can just be updated in the documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generated on the fly from src/coreComponents/mesh/docs/MeshObjectInstantiationHierarchy.plantuml

Copy link
Contributor

@sframba sframba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Randy, a couple typos in the names

src/docs/JOSS/paper.md Outdated Show resolved Hide resolved
src/docs/JOSS/paper.md Outdated Show resolved Hide resolved
@rrsettgast rrsettgast changed the title GEOS paper submittal to JOSS docs: GEOS paper submittal to JOSS Sep 16, 2024
@rrsettgast rrsettgast self-assigned this Sep 16, 2024
@rrsettgast rrsettgast marked this pull request as ready for review September 17, 2024 00:20
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.31%. Comparing base (3b5b5a6) to head (527ce5b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2886      +/-   ##
===========================================
- Coverage    56.59%   56.31%   -0.29%     
===========================================
  Files         1064     1065       +1     
  Lines        89766    90227     +461     
===========================================
  Hits         50807    50807              
- Misses       38959    39420     +461     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsettgast rrsettgast closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants