-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove circular dependencies from fileIO/common/codingutilities #3247
refactor: Remove circular dependencies from fileIO/common/codingutilities #3247
Conversation
- no runtime types nor Mpi constants - DataTypes.cpp is not useful anymore.
…sicIO&format-under-common
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3247 +/- ##
===========================================
- Coverage 55.92% 55.91% -0.02%
===========================================
Files 1042 1043 +1
Lines 88923 88934 +11
===========================================
- Hits 49733 49729 -4
- Misses 39190 39205 +15 ☔ View full report in Codecov by Sentry. |
…-circular-fileIO&common-dependancies
3ed38d8
to
6981b3b
Compare
@rrsettgast @CusiniM I reverted the branch to the commit before the "MPI_COMM_GEOSX to MPI_COMM_GEOS" because this renaming now has its own PR. |
…-circular-fileIO&common-dependancies
…ties (#3247) * DataTypes.hpp now only manage static types - no runtime types nor Mpi constants - DataTypes.cpp is not useful anymore. * removing common -> fileIO * removing common->codingUtilities * logger has now a dedicated folder for upcoming files (future PRs) ---------
…ties (#3247) * DataTypes.hpp now only manage static types - no runtime types nor Mpi constants - DataTypes.cpp is not useful anymore. * removing common -> fileIO * removing common->codingUtilities * logger has now a dedicated folder for upcoming files (future PRs) ---------
The point of this PR is to solve the circular dependencies of
fileIO
,common
andcodingutilities
by:basicIO
andformat
incommon
.format
will containFormat.*pp
,fileIO/Table/*
,fileIO/Section/*
fileIO <-> common
logger
: will contain utilities logging (only one file for now but is going to grow)DataType.*pp
by making it only related to static types:rtTypes
&Regex
will be incodingUtilities
, aside ofStringEnums.hpp
codingUtilities <-> common
DataType.cpp