refactor: EnumStrings.hpp from codingUtilities to common/format #3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no runtime types nor Mpi constants - DataTypes.cpp is not useful anymore.
…sicIO&format-under-common
…-circular-fileIO&common-dependancies
…-circular-fileIO&common-dependancies
… into feature/rey/refactor-stringenums-to-common
MelReyCG
requested review from
rrsettgast,
corbett5,
wrtobin,
castelletto1,
CusiniM and
paveltomin
as code owners
|
@rrsettgast @corbett5 @wrtobin @untereiner, may I ask you a review as you guys are the concerned codeowners? |
untereiner
approved these changes
Aug 27, 2024
inputFiles/singlePhaseFlowFractures/fractureFlow_conforming_2d_vtk_input.xml
Outdated
Show resolved
Hide resolved
…or-stringenums-to-common
MelReyCG
changed the title
rrsettgast
approved these changes
Nov 5, 2024
…or-stringenums-to-common
MelReyCG
requested review from
frankfeifan,
ryar9534 and
Guotong-Ren
as code owners
paveltomin
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is after the #3247, and aim to relocate
EnumStrings.hppat a lower level, in thecommon/formatpackage. The goal is to allow basic components, such as the upcoming logger (incommon/logger), to depend on it, without relying on a circular header dependency.