Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Time-saving version of PR #3159 that adds Pangea3 job with ppc emulation #3340

Merged
merged 69 commits into from
Sep 13, 2024

Conversation

Algiane
Copy link
Contributor

@Algiane Algiane commented Sep 9, 2024

This PR:

  • build only the geos executable (and do not build the unit test anymore)
  • build only the WaveSolver solver of geos

Algiane and others added 30 commits June 21, 2024 15:40
change launch parameters for pangea3 CI build

Co-authored-by: Matteo Cusini <49037133+CusiniM@users.noreply.github.com>
Remove double link of statics libs when building some of the unit tests. This error creates 'multiple definition' error at link edition on Pangea3.
… processes are not modified by this PR and still use Ninja generator.
…rrent ci processes are not modified by this PR and still use Ninja generator."

This reverts commit 66ed037.
@Algiane Algiane added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires updated TPL(s) Needs a specific TPL PR type: CI Concerns github workflows or generic CI DO NOT MERGE ! flag: no rebaseline Does not require rebaseline labels Sep 9, 2024
@Algiane Algiane self-assigned this Sep 9, 2024
@Algiane Algiane requested a review from rrsettgast as a code owner September 9, 2024 14:31
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.59%. Comparing base (dc604e5) to head (bece5e4).
Report is 82 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3340      +/-   ##
===========================================
- Coverage    56.59%   56.59%   -0.01%     
===========================================
  Files         1064     1064              
  Lines        89766    89766              
===========================================
- Hits         50807    50805       -2     
- Misses       38959    38961       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane marked this pull request as ready for review September 12, 2024 14:08
@Bubusch
Copy link
Contributor

Bubusch commented Sep 12, 2024

streak-2 8 cores -> 1h 35m 36s

@Bubusch
Copy link
Contributor

Bubusch commented Sep 13, 2024

streak-2 8 cores + cache -> 47min

@Bubusch Bubusch added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Sep 13, 2024
@rrsettgast
Copy link
Member

@Algiane @Bubusch
I am removing the DO NOT MERGE! label and putting this on the queue

@rrsettgast rrsettgast merged commit 0ba1f36 into develop Sep 13, 2024
25 checks passed
@rrsettgast rrsettgast deleted the feature/algiane/pangea3-action-light branch September 13, 2024 19:42
rrsettgast pushed a commit that referenced this pull request Sep 17, 2024
…ulation (#3340)

* Add pangea-3 job and emulation step.

* Replace relative path in cmake for P3-wave-solver host-config file.

* Build wave solver only in Pangea 3 job.

* Build Geos executable only in Pangea 3 job.

---------

Co-authored-by: Gaetan <159525405+Bubusch@users.noreply.github.com>
rrsettgast pushed a commit that referenced this pull request Sep 17, 2024
…ulation (#3340)

* Add pangea-3 job and emulation step.

* Replace relative path in cmake for P3-wave-solver host-config file.

* Build wave solver only in Pangea 3 job.

* Build Geos executable only in Pangea 3 job.

---------

Co-authored-by: Gaetan <159525405+Bubusch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: requires updated TPL(s) Needs a specific TPL PR type: CI Concerns github workflows or generic CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants