Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of new features to generate ocean boundary conditions for atmosphere-only **forecasts** #47

Merged
merged 22 commits into from
Jan 25, 2024
Merged

Addition of new features to generate ocean boundary conditions for atmosphere-only **forecasts** #47

merged 22 commits into from
Jan 25, 2024

Conversation

sanAkel
Copy link
Collaborator

@sanAkel sanAkel commented Jan 18, 2024

The PR adds 3 utilities to:

  1. Extract daily data from GMAO operations yearly archive of ocean boundary conditions (BCs).
  2. Generate daily climatology from above for any given date.
  3. Create (in different methods: persistence of initial BCs, persistence of initial anomaly in BCs) BCs for forecasts.

No change in answers because it adds new utilities to pre/prepare_ocnExtData, utilities therein are so far not used by any GEOS application other than diagnostics.

sanAkel added 16 commits October 21, 2023 15:43
1. Add main program: sst_ice_helpers.F90 - to calculate daily clim, 2…
b8411d7 
…. Adjust CMakeLists, 3. Add scanner/reader of DAO OPS binary file.
to generate conservative regridding weights to map original OSTIA dat…
e02b65d 
…a to GEOS 1/8-deg grid: use xesmf
Plot difference between conservatively remapped and binned (GEOS FP b…
4078730 
…inary file)
Add utility to extract SST and Ice concentration for any given day: e…
b8c592b 
…xtract_daily_sst_ice.x 2023 1 5
get rid of commented line
c668923
Added time ticker from @rtodling
026c86e
Getting there! Add standard deviation calculation and user input args
78bc8c1
Working daily climatology production- including leap year/day (02/29)
0e00190
remove hard coded file prefix/suffix
c9c4630
Improve readability
860920c
Add option to save binary file
90a3430
Make defaults argument(s), as asked by @rtodling for input BCS data p…
e4ac9c5 
…ath. Followed his example code: https://github.com/GEOS-ESM/GMAO_Shared/blob/main/GMAO_hermes/dyn_recenter.f90
add utility to generate forecast (persistence), clean up
a1c5752
remove commented lines
3481694
Add option to generate BCs using persistence of initial anomaly
69ccffc
update change log
a80a172
@sanAkel sanAkel added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request labels Jan 18, 2024
@sanAkel sanAkel requested a review from rtodling January 18, 2024 00:03
@sanAkel sanAkel self-assigned this Jan 18, 2024
@sanAkel sanAkel requested review from a team as code owners January 18, 2024 00:03
@sanAkel sanAkel requested a review from mathomp4 January 18, 2024 00:04
mathomp4
mathomp4 reviewed Jan 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sanAkel
Update CHANGELOG.md
3210ede 
addressing #47 (comment) from @mathomp4
@sanAkel
Update gen_wts_regrid_ostia_geos.py
176f65b 
change python3 directive to python to accommodate GEOSadas which apparently is not caught up with python3 (per @rtodling)
@sanAkel
Update plot_diff_ostia_native_regridded_binned.py
2f44d77 
change python3 directive to python to accommodate GEOSadas which apparently is not caught up with python3 (per @rtodling)
mathomp4
mathomp4 previously approved these changes Jan 19, 2024
View reviewed changes
@mathomp4 mathomp4 self-requested a review January 19, 2024 13:14
mathomp4
mathomp4 previously approved these changes Jan 19, 2024
View reviewed changes
@mathomp4 mathomp4 self-requested a review January 25, 2024 18:44
@sdrabenh sdrabenh merged commit d300390 into main Jan 25, 2024
7 checks passed
@sdrabenh sdrabenh deleted the sanAkel/feature/oceanBCs_clim_anom branch January 25, 2024 19:18
@sanAkel sanAkel mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@rtodling rtodling Awaiting requested review from rtodling

Assignees

@sanAkel sanAkel

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanAkel @mathomp4 @sdrabenh