Forecast boundary condition: threshold ice concentration for anomaly persistence #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanAkel
added
the
0 diff
sanAkel
changed the title
sanAkel
changed the title
|
Santha, this seems fine, but to make sure I am running over the data you re-created w/ these fixes. I will let you know. |
@rtodling, Yes please let me know if those (new files) cause any errors. 🙏 |
|
two runs have completed successfully! I'd say the code changes work fine. |
mathomp4
approved these changes
Feb 29, 2024
sdrabenh
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a patch to previous PR for following case:
of creation of boundary conditions (SST and sea ice concentration; atmosphere-only configuration) using persistence of initial anomaly.
As found by @rtodling, the anomaly persistence can create sea ice concentrations that are
> 1or< 0which are unphysical and not allowed by the GEOS data sea ice component indefaultsettings.Proposed patch avoids such instances and also adjusts
SSTwhen we know how to do that, therefore ice concentrations and SST have (some) consistency.