Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit CONTACT to History #367

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Oct 6, 2022

Due to a request from NOAA, in an upcoming version of MAPL, the default Contact: normally inserted into History output will change from http://gmao.gsfc.nasa.gov to a blank string.

In order to keep history metadata the same, this PR adds:

CONTACT: 'http://gmao.gsfc.nasa.gov'

to all HISTORY files in this repo.

Note that this is a no-op as this just overrides the default Contact: in the History output to be the current default.


Files changed by:

$ sed -e "/^ *COLLEC/i CONTACT: 'http://gmao.gsfc.nasa.gov'\n" -i HIST*

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 6, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner October 6, 2022 17:31
@mathomp4 mathomp4 self-assigned this Oct 6, 2022
@mathomp4
Copy link
Member Author

Note to @sdrabenh: MAPL 2.28 is now out with this change to CONTACT. I'll make a PR in GEOSgcm for this and note we need this PR as well at the same time for complete metadata zero-diff.

@sdrabenh sdrabenh merged commit dcc863c into develop Oct 18, 2022
@sdrabenh sdrabenh deleted the feature/mathomp4/add-contact-to-history branch October 18, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants