Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1694. Remove URLs from MAPL #1715

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Oct 6, 2022

Description

This PR removes URLs (websites and email addresses) from MAPL per the request of NOAA. Note that this means that History output now has a BLANK Contact: global metadatum by default. If you wish to duplicate previous output, you'd want to set:

CONTACT: 'http://gmao.gsfc.nasa.gov'

in HISTORY.rc

There is a PR in GEOSgcm_App to do this for GEOS:

GEOS-ESM/GEOSgcm_App#367

Related Issue

Closes #1694

Motivation and Context

Per request of NOAA.

How Has This Been Tested?

It runs and is zero-diff in the state and in History if HISTORY.rc change is made. Note that one has to specifically compare global metadata to see the History difference without the change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 6, 2022
@mathomp4 mathomp4 self-assigned this Oct 6, 2022
@mathomp4 mathomp4 requested review from a team as code owners October 6, 2022 17:05
@mathomp4 mathomp4 requested a review from rmontuoro October 6, 2022 17:31
@mathomp4 mathomp4 merged commit 7a1008d into develop Oct 6, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/1694-remove-urls branch October 6, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants